Ticket #968 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 weeks ago

Checkable MenuItem

Reported by: joose Owned by: nonken
Priority: normal Milestone: 1.2
Component: themes Version: 0.3
Severity: normal Keywords: MenuItem
Cc: toonetown

Description (last modified by bill) (diff)

Seems like MenuItem? is missing checkable menuitem, where you can select items on or off.. Like this:

  Use foo
* Use bar
* Use Quux

So that would indicate that bar and quux are turned on. of course corresponding events to match turning on/off perhaps?

Attachments

CheckableMenuItem.patch (1.5 kB) - added by joose 18 months ago.
makes "checking" of menuitem possible
CheckableMenuItem-test.patch (0.8 kB) - added by joose 18 months ago.
Patch to test-file
CheckableMenuItem.js (3.2 kB) - added by joose 18 months ago.
Now default values work as supposed. Also setChecked(boolean) is there.
checkableMenu.diff (6.2 kB) - added by nathan 5 weeks ago.
Here's a patch against current head to implement this - if anyone is interested in resurrecting this issue.

Change History

Changed 2 years ago by dylan

  • milestone changed from 0.4 to 0.5

Changed 18 months ago by joose

  • owner changed from anonymous to bill

I made simple patch to make this possible. What it still requires actually is:

- Image of "checked" thing.

- To make default value working (isChecked=true)

How it works, just add checkable="true" and default value is defined by isChecked (boolean)

Changed 18 months ago by joose

makes "checking" of menuitem possible

Changed 18 months ago by joose

Patch to test-file

Changed 18 months ago by joose

Now default values work as supposed. Also setChecked(boolean) is there.

Changed 14 months ago by bill

  • component changed from Widgets to Dijit
  • milestone changed from 0.9 to 1.0

Hmm, will consider for 1.0.

Changed 14 months ago by joose

  • cc joose@… removed
  • reporter changed from joose@iki.fi to joose

Changed 10 months ago by bill

  • milestone changed from 1.0 to 2.0

Changed 5 months ago by alex

  • milestone changed from 2.0 to 1.3

Milestone 2.0 deleted

Changed 5 weeks ago by nathan

Here's a patch against current head to implement this - if anyone is interested in resurrecting this issue.

Changed 4 weeks ago by toonetown

  • status changed from new to closed
  • resolution set to fixed

(In [14070]) Fixes #968 - adds dijit.CheckedMenuItem? for toggle-based menu items !strict

Changed 4 weeks ago by toonetown

(In [14072]) Refs #968 - fix role for a11y !strict

Changed 4 weeks ago by bill

  • status changed from closed to reopened
  • component changed from Dijit to a11y - review
  • resolution deleted
  • description modified (diff)
  • milestone changed from 1.3 to 1.2

Just sending to Becky for testing screen reader.

Changed 4 weeks ago by nathan

  • cc nathan added

Changed 4 weeks ago by bill

  • status changed from reopened to new
  • owner changed from bill to becky

Changed 4 weeks ago by toonetown

(In [14086]) Refs #968 - toggling should not happen when item is disabled !strict

Changed 4 weeks ago by toonetown

(In [14106]) Refs #968 - remove width 100%, since it is not needed

Changed 4 weeks ago by becky

The aria roles and properties look correct. Unfortunately the screen reader doesn't understand checkable menuitems, yet, so it doesn't say anything different to distinguish the checkable from the regular menu items. However, the correct role is being set so it has been implemented properly.

However, all of the other menu items are counted and an AccessibleDescription? is generated that is "x of 8" where x is the number of the current menu item in the list of 8 items. With the 3 new checkable items added, it should be "x of 11" but the checkable menu items aren't counted and do not get an accessibleDescription. I filed this as a Firefox bug (https://bugzilla.mozilla.org/show_bug.cgi?id=441888) but when I look at the HTML in Firebug, I don't see the checkable items in the table that gets generated for the menu? Can anyone figure out why not? That may be the issue. The HTML in test_menu.html looks correct and the menu divs seem to be nested properly.

Changed 3 weeks ago by becky

  • component changed from a11y - review to Dijit

correct aria has been implemented and firefox bug has been fixed so moving this out of a11y-review back to dijit.

Changed 3 weeks ago by becky

  • owner changed from becky to nathan

Changed 3 weeks ago by nathan

  • owner changed from nathan to nonken
  • component changed from Dijit to themes

I think this is completed - with the exception of (possibly) having different icons than the ones used - Moving to nikolai since he is a bit better-qualified at making that decision.

Changed 2 weeks ago by toonetown

  • cc toonetown added; nathan removed

Changed 2 weeks ago by nonken

(In [14285]) Optimized css, only using gif and fixed potential bug not displaying the checkboxes, refs #968

Changed 2 weeks ago by nonken

I think the way it looks now is good and suggest closing the ticket, I tried with a no border image but using the standard checkbox somehow gives a more unified look, also because the sub menu icons are the same as everywhere as well

Changed 2 weeks ago by toonetown

  • status changed from new to closed
  • resolution set to fixed

Marking as closed then.

Note: See TracTickets for help on using tickets.