Ticket #7595 (closed defect: fixed)
dataObject.length undefined in ComboBox.js (breaks paging with QueryReadStore)
| Reported by: | stekell2 | Owned by: | anonymous |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2 |
| Component: | General | Version: | 1.2beta |
| Severity: | normal | Keywords: | ComboBox FilteringSelect QueryReadStore Paging |
| Cc: |
Description
dataObject.length should probably be dataObject.count in ComboxBox?.js at line 794 At least that change seemed to get paging working for me again.
As it is, it's undefined and causes displayMore to not be set to true for that case. Meaning a common use case of using ComboxBox/FilteringSelect? with a QueryReadStore? will fail to show "More Choices" when it should.
BTW It surprised that it doesn't actually throw a JavaScript? error when adding the undefined object. This may be why it's escaped your testing. It just skips past it when should have evaluated to true and set displayMore. It drove me crazy for awhile because firebug made it look like it was getting to the if-body.
I don't know if this will fix this person's problem that you couldn't duplicate: http://trac.dojotoolkit.org/ticket/6690 but it looks like that error existing before that patch as well.
