Ticket #7465 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

grid autoHeight

Reported by: maulin Owned by: toonetown
Priority: normal Milestone: 1.2
Component: DojoX Grid Version: 1.1.1
Severity: normal Keywords:
Cc:

Description

if grid belongs to a parent node with height=0, then setting autoHeight=true on the markup works as expected, EXCEPT that the header row is not visible (going into firebug and changing style on header to have height=33px, makes it show up.) attached is test case.

Attachments

test_data_grid_autoHeightBug.html (1.7 kB) - added by maulin 11 months ago.
test_data_grid_autoHeightBug.2.html (1.7 kB) - added by maulin 11 months ago.
autoHeight bug where set to number > rowCount
_Grid.js.patch (430 bytes) - added by maulin 11 months ago.

Change History

Changed 11 months ago by maulin

Changed 11 months ago by maulin

additionally, if you set autoHeight=number, where number is > than the number of rows returned, you also lose the header (though if number is < rowCount, it works as expected). I also attached a test case for that

Changed 11 months ago by maulin

autoHeight bug where set to number > rowCount

Changed 11 months ago by maulin

I think I found the source: Line 587-588 of _Grid show:

// Otherwise, show the header and give it an appropriate height.

this.viewsHeaderNode.style.display = "block";

but the "give it an appropritate height part is never called. I added:

// Otherwise, show the header and give it an appropriate height.

this.viewsHeaderNode.style.display = "block"; this._getHeaderHeight();

and it works fine!(and yes, I have signed the CLA)

Changed 11 months ago by maulin

Changed 11 months ago by BryanForbes

  • owner changed from BryanForbes to toonetown

Changed 11 months ago by toonetown

  • status changed from new to closed
  • resolution set to fixed

(In [14929]) Fixes #7465 - when changing the display of the header node, recalculate the height. Thanks for the patch !strict

Note: See TracTickets for help on using tickets.