Ticket #7218 (closed defect: fixed)

Opened 12 months ago

Last modified 11 months ago

GridContainer doesn't update grip handles when PlottedDnd shows a DropIndicator

Reported by: jbalogh Owned by: dante
Priority: normal Milestone: 1.2
Component: Dojox Version: 1.1.1
Severity: normal Keywords:
Cc:

Description

Using the 2nd GridContainer? on http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/layout/tests/test_GridContainer.html:

  1. Observe that the middle column is full; it will have to expand vertically if we try to drop another element on it.
  2. Drag an object from the first or third columns, and hover it over the middle column so you see the outlined box showing where the dropped item will go.
  3. Notice that the grips are floating in space, since the container has dynamically resized but the grips didn't extend.

See the attached screenshot for an example.

Attachments

floating_grips.png (121.3 kB) - added by jbalogh 12 months ago.
Screenshot of GridContainer? grips floating in space.
0001-Connect-_placeGrips-to-insertion-and-deletion-of-dro.patch (0.8 kB) - added by jbalogh 12 months ago.
patch to fix grip placement

Change History

Changed 12 months ago by jbalogh

Screenshot of GridContainer? grips floating in space.

Changed 12 months ago by jbalogh

patch to fix grip placement

Changed 12 months ago by jbalogh

The attached patch connects the _placeGrips function to the dropIndicator events. It's not perfect though, because you can create a noticeable flicker if the DashedZone gets inserted and deleted rapidly (which happens sometimes when the dragged element is in between other elements). But the patch is an improvement over having the grips floating in space.

The flicker problem could possibly be solved by making the DashedZone less sensitive, but I haven't looked into that yet.

And yes, the patch looks funny, but patch -p0 does the right thing; I tested it.

Changed 12 months ago by dante

  • owner changed from peller to dante
  • status changed from new to assigned

Changed 11 months ago by dante

  • milestone changed from tbd to 1.2

Changed 11 months ago by dante

  • status changed from assigned to closed
  • resolution set to fixed

(In [14599]) fixes #7218 - make grips extend to container size should the container resize during drag/positioning. !strict

Note: See TracTickets for help on using tickets.