Ticket #7128 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

In dojox.math, the factorial function is misspelled as "factoral"

Reported by: enzo Owned by: ttrenka
Priority: normal Milestone: 1.2
Component: Dojox Version: 1.1.1
Severity: minor Keywords:
Cc: ttrenka

Description

It may be advisable to rename it as "factorial", and add a "factoral" function that just return the former in order to preserve compatibility.

Attachments

_base.diff.js (0.9 kB) - added by nic 5 months ago.

Change History

  Changed 5 months ago by ttrenka

  • owner changed from anonymous to ttrenka

  Changed 5 months ago by ttrenka

  • milestone changed from tbd to future

  Changed 5 months ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [14368]) Correct typo in method name "factoral" -> "factorial". It's experimental code, so users will have to migrate. Better now than later. Fixes #7128

  Changed 5 months ago by peller

  • component changed from General to Dojox
  • milestone changed from future to 1.2

Changed 5 months ago by nic

follow-up: ↓ 7   Changed 5 months ago by nic

"factoral": five occurencies in _base.js
!0 is defined = 1

Nicola Rizzo

[ccla] nicola@…

  Changed 5 months ago by nic

  • status changed from closed to reopened
  • resolution deleted

in reply to: ↑ 5   Changed 5 months ago by nic

Replying to nic:

"factoral": five occurencies in _base.js
!0 is defined = 1 Nicola Rizzo [ccla] nicola@…

0! = 1

not !0 :)

  Changed 5 months ago by peller

  • status changed from reopened to closed
  • resolution set to fixed

(In [14374]) Fix factorial, hopefully correctly this time. thanks, nic. Fixes #7128

Note: See TracTickets for help on using tickets.