Ticket #7115 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

this vs. self mismatch in DropDownButton's popup onClose args

Reported by: humbletim Owned by: bill
Priority: normal Milestone: 1.2
Component: Dijit Version: 1.1.1
Severity: normal Keywords: dijit.form.Button dijit.form.DropDownButton
Cc: tdedischew@…

Description

in dijit/form/Button.js @ _openDropdown:249

			onCancel: function(){
				self._closeDropDown(true);
			},
			onClose: function(){
				dropDown.domNode.style.width = oldWidth;
				self.popupStateNode.removeAttribute("popupActive");
				this._opened = false;
			}

this._opened = false; should be self._opened = false;

Change History

Changed 5 months ago by bill

  • owner changed from anonymous to bill
  • status changed from new to assigned
  • component changed from General to Dijit
  • milestone set to 1.2

thanks for catching that, will fix

Changed 5 months ago by bill

  • status changed from assigned to closed
  • resolution set to fixed

(In [14272]) fix typo. fixes #7115. !strict

Note: See TracTickets for help on using tickets.