Ticket #693 (closed defect: invalid)

Opened 2 years ago

Last modified 14 months ago

Issue with dojo.event.connect ordering of method calls

Reported by: anonymous Owned by: alex
Priority: normal Milestone:
Component: General Version: 0.2
Severity: normal Keywords:
Cc:

Description

I believe that there is a bug in dojo.event.connect when using after and around advice on the same method.

This may be a failure on my understanding, or a design decision for it to work this way, however I don't agree that the current implementation is correct.

I have attached a test html file.

In short :

dojo.debug('expect around-before, clicked, after, around-after'); dojo.debug('actual around-before, clicked, around-after, after'); var button1 = new Button(); dojo.event.connect('after', button1, 'onclick', afterHandler); dojo.event.connect('around', button1, 'onclick', aroundHandler); button1.onclick();

Attachments

test_Events.htm (1.6 kB) - added by cameron@… 2 years ago.

Change History

Changed 2 years ago by cameron@…

Changed 2 years ago by anonymous

this should make it easier to read :

dojo.debug('expect around-before, clicked, after, around-after'); 
dojo.debug('actual around-before, clicked, around-after, after'); 
var button1 = new Button(); 
dojo.event.connect('after', button1, 'onclick', afterHandler); 
dojo.event.connect('around', button1, 'onclick', aroundHandler); 
button1.onclick();

Changed 2 years ago by bill

  • owner changed from anonymous to alex
  • milestone set to 0.4

Alex?

Changed 2 years ago by alex

  • status changed from new to closed
  • resolution set to invalid

this is the as-deisgned behavior. If we're going to discuss if it should be changed, I'm ok with that, but perhaps in a separate enahancement bug?

Marking "invalid". Wish we had a less quarelsome tag for this kind of resolution...perhaps "under-documented" ;-)

Changed 14 months ago by anonymous

  • milestone deleted

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.