Ticket #6764 (closed defect: fixed)

Opened 7 months ago

Last modified 5 months ago

BorderContainer support padding

Reported by: nonken Owned by: peller
Priority: normal Milestone: 1.2
Component: Dijit - LnF Version: 1.1.0
Severity: normal Keywords: BorderContainer, Padding
Cc: bill, nonken, sfoster

Description (last modified by nonken) (diff)

To create a more solid L&F each bordercontainer which is using splitters as well should have a default padding with the bgcolor of the splitter. Using this padding the splitters will not end up in nothing but the BorderContainer?'s children will be embedded in the BorderContainer? resulting in an improved L&F. For BC elements not having a splitter you should be able to set that padding to 0

Attachments

BCpadding.png (104.3 kB) - added by nonken 7 months ago.
This BorderContainer? has a "padding" note the browser does not have a correct window size
BCnopadding.png (105.9 kB) - added by nonken 7 months ago.
Current BC style

Change History

Changed 7 months ago by nonken

  • cc sfoster added

Changed 7 months ago by nonken

This BorderContainer? has a "padding" note the browser does not have a correct window size

Changed 7 months ago by nonken

Current BC style

Changed 7 months ago by nonken

  • description modified (diff)

Changed 7 months ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [13743]) Compute layout with padding. Fixes #6764 !strict

Changed 6 months ago by nonken

(In [13928]) removed default border on BorderContainer?, refs #6764

Changed 6 months ago by nonken

(In [13930]) set width/height to 100%, refs #6764

Changed 6 months ago by nonken

(In [13933]) fixed so BorderContainer? supports 100% width/height + padding, refs #6764 !strict

Changed 6 months ago by nonken

(In [13948]) fixed themeTester layout, Refs #6764

Changed 5 months ago by bill

(In [14414]) Fix non-portable code for padding calculations, refs #6764 !strict. This fixes mail demo editor layout problems in safari, refs #7096, #7097.

Changed 5 months ago by bill

(In [14419]) Oops, forgot node argument to _toPixelValue(). refs #6764 !strict.

Changed 5 months ago by nonken

  • status changed from closed to reopened
  • resolution deleted

Now BC doesn't have the padding anymore on bottom and left. check themeTester.html to see. Probably some regression

Changed 5 months ago by bill

  • status changed from reopened to closed
  • resolution set to fixed
  • milestone set to 1.2

Yah, I broke this but then fixed it above in [14419].

Note: See TracTickets for help on using tickets.