Ticket #6595 (closed enhancement: fixed)

Opened 22 months ago

Last modified 21 months ago

Add a new data store for Google search

Reported by: sos Owned by: jaredj
Priority: normal Milestone: 1.2
Component: DojoX Data Version: 1.1.0
Severity: normal Keywords:
Cc:

Description

Google make their search API available as a RESTful service. A dojox.data store should be written to access it.

Attachments

GoogleSearch.patch (34.1 kB) - added by sos 22 months ago.
Patch to implement this feature
GoogleSearch_multipleStores.patch (45.9 kB) - added by sos 22 months ago.
Update patch that implements multiple different stores, one for each type of search
dojox.data.GoogleSearchStore_20080501.patch (49.2 kB) - added by jaredj 22 months ago.
My version of the patch with extra demo + some attempted fixes.
dojox.data.GoogleSearchStore_20080501_2.patch (49.2 kB) - added by sos 22 months ago.
Updated patch with paging errors fixed
dojox.data.GoogleSearchStore_20080501_3.patch (53.8 kB) - added by sos 22 months ago.
Patch with more fixes, and tests for Image gallery and Slideshow
dojox.data.GoogleSearchStore_20080501_4.patch (54.1 kB) - added by jaredj 22 months ago.
More cleanup. Fixed a few accidental globals, one invalid test, some structure, and jslint complaints.
GoogleSearch_args.patch (3.9 kB) - added by sos 21 months ago.
Fixes checking of contructor args
GoogleFeedStore_Initial.patch (30.6 kB) - added by sos 21 months ago.
Patch that implements a store that accesses Google's Feed API. Use this instead of the previous patch!
GoogleSearch_dijitRequire.patch (5.7 kB) - added by sos 21 months ago.
Performance improvement for the demos

Change History

Changed 22 months ago by sos

Patch to implement this feature

Changed 22 months ago by sos

I've discovered a bug with the store, relating to using non-web based search, e.g. blogs. This will be fixed tonight, and a new patch submitted

Changed 22 months ago by sos

Update patch that implements multiple different stores, one for each type of search

Changed 22 months ago by jaredj

Will look at this soon! This sounds really cool. Thanks for doing the initial work on it. :)

Changed 22 months ago by jaredj

Looked at it a bit, fixed a few things, added a demo that attaches it to grid, tried to remove the usage of simpleFetch, though I don't know if that is necessary

Overall, I think you have some bugs in the paging mechanism. Start/count don't work quite as expected when it is trying to get subsets. This shows up particularly in grid. For some reason it only shows the first page. Could you take a look at your paging logic again and see why it is acting funny? I looked over it some, and will do so more later, but I haven't figured it quite out yet.

Changed 22 months ago by jaredj

My version of the patch with extra demo + some attempted fixes.

Changed 22 months ago by sos

Sure, will look in to it. Do you know of any specific tests, or combination of tests, that it fails? I included all the standard tests, which it passes. Perhaps we need to extend the basic set of tests for more coverage.

Changed 22 months ago by sos

Updated patch with paging errors fixed

Changed 22 months ago by sos

Patch with more fixes, and tests for Image gallery and Slideshow

Changed 22 months ago by sos

Patch dojox.data.GoogleSearchStore?_20080501_3.patch also includes a fix for dojox.image.Gallery, where it was broken if a store other than one of the Flickr stores was used.

Changed 22 months ago by jaredj

More cleanup. Fixed a few accidental globals, one invalid test, some structure, and jslint complaints.

Changed 22 months ago by jaredj

  • status changed from new to closed
  • resolution set to fixed

(In [13527]) Awesome collaborative work from Shane O'Sullivan and Jared J. fixes #6595 \!strict

Changed 22 months ago by jaredj

(In [13538]) Fix to demo with grid, css path issue. refs #6595

Changed 21 months ago by sos

Fixes checking of contructor args

Changed 21 months ago by sos

Patch that implements a store that accesses Google's Feed API. Use this instead of the previous patch!

Changed 21 months ago by jaredj

(In [13592]) Minor updates to GoogleSearchStore? + the GoogleFeedStore? extension. Many thanks ot Shane for his hard work on them. refs #6595 \!strict

Changed 21 months ago by jaredj

Added in Shane's addition after a quick review. Tested it all on FF 2, IE 6, Seamonkey 1.1.2, and Safari 3.1

Changed 21 months ago by jaredj

  • milestone set to 1.2

Changed 21 months ago by sos

Performance improvement for the demos

Note: See TracTickets for help on using tickets.