Ticket #6582 (new task)

Opened 3 months ago

Last modified 7 days ago

land editor refactor to remove iframes in most situations

Reported by: alex Owned by: alex
Priority: high Milestone: 1.2
Component: Editor Version: 1.1.0
Severity: normal Keywords:
Cc: liucougar

Description

like it says on the tin. The editor may be horribly broken after this change.

Change History

Changed 3 months ago by alex

(In [13373]) lands the RichText? refactor to remove use of iframes unless explicitly requested or on a degenerate browser (e.g., FF2). Refs #6582. !strict

Changed 3 months ago by liucougar

(In [13374]) refs #6582: re-merge [13304], [13328], [13335], [13262] and [13257] which were lost in the refactor

Changed 3 months ago by liucougar

(In [13375]) refs #6582: use dijit._editor.getChildrenHtml instead of Editor.getChildrenHtml

Changed 3 months ago by liucougar

(In [13382]) refs #6582: detect useIframe correctly when styleSheets or useIframe is explicitly specified refs #6584: fix broken auto-expand when iframe is used refs #6583: enable alwaysshowtoolbar plugin for editor when iframe is used (which is needed to support auto-expand)

Changed 3 months ago by peller

(In [13577]) Fixes #6376 on 1.1 branch only, to defer setValue if editor is still loading. No longer a problem on trunk after Alex's refactor (see #6582)

Changed 7 days ago by peller

  • priority changed from normal to high
  • component changed from General to Editor

Changed 7 days ago by bill

  • type changed from enhancement to task

Notes from Alex at dojo meeting a few days ago, about remaining work on this:

Remaing work deals w/focus.

Tabbing from the toolbar to the editor itself is b0rken now that they're in the same document (the selection range gets oblitterated, etc). So calling the commands doesn't "work" the way it used to since the selection may be hosed so the selection range gets collapsed when you focus on something else and the undo stack gets polluted.

Anyway, we've noted this all before. The solution is to excise the command system and make sure that focus events preserve selection at all times.

Changed 7 days ago by liucougar

just tried tab/shift-tab in the editor, it does not invalidate the selection in editor

Note: See TracTickets for help on using tickets.