Ticket #6506 (closed defect: fixed)

Opened 8 months ago

Last modified 5 months ago

[patch] ComboBox: when drop down opened, escape shouldn't revert value, just close drop down

Reported by: bill Owned by: haysmark
Priority: normal Milestone: 1.2
Component: Dijit Version: 1.1.0
Severity: normal Keywords:
Cc:

Description (last modified by bill) (diff)

When the drop down is open ESC should close it; hitting ESC an additional time should revert the value. At least arguably so (see forum discussion).

Currently, on test_ComboBox.html,

  1. in first combobox, erase the value and type "al"
  2. press down arrow key twice to get to "Alaska" (so that Alaska is also displayed in the input box)
  3. press ESC

At this point the drop down closes and the input box returns to "Iowa". Seems inconsistent w/how we are handling esc for other widgets with drop downs?

Attachments

6506.patch (404 bytes) - added by haysmark 7 months ago.
Fixes #6506. ComboBox? doesn't revert the value/close the parent dialog/etc when you press Escape and the ComboBox? menu is still open.

Change History

Changed 8 months ago by bill

  • description modified (diff)

Changed 7 months ago by haysmark

Fixes #6506. ComboBox? doesn't revert the value/close the parent dialog/etc when you press Escape and the ComboBox? menu is still open.

Changed 7 months ago by haysmark

  • status changed from new to assigned
  • owner changed from doughays to haysmark
  • summary changed from ComboBox: when drop down opened, escape shouldn't revert value, just close drop down to [patch] ComboBox: when drop down opened, escape shouldn't revert value, just close drop down

Changed 5 months ago by haysmark

  • status changed from assigned to closed
  • resolution set to fixed

Revision: 14220 Author: bill Date: 2:12:10 AM, Wednesday, July 02, 2008 Message: Fixes #6390: Can't search all in ComboBox? / FilteringSelect? Patch from Mark Hays. !strict

Modified : /dijit/trunk/form/ComboBox.js Modified : /dijit/trunk/tests/form/test_ComboBox.html

Changed 5 months ago by bill

Actually I checked in your patch in [14221], which should have closed this ticket automatically.

Changed 5 months ago by haysmark

Yeah it's weird that there was no message. I must have misclicked.

Revision: 14221 Author: bill Date: 2:24:05 AM, Wednesday, July 02, 2008 Message: Fixes #6506: ComboBox?: when drop down opened, escape shouldn't revert value, just close drop down Patch from Mark Hays. !strict

Modified : /dijit/trunk/form/ComboBox.js

Note: See TracTickets for help on using tickets.