Ticket #6481 (closed enhancement: fixed)

Opened 8 months ago

Last modified 7 months ago

[patch] [cla] Slide direction control for dojox.layout.RadioGroup.js

Reported by: guest Owned by: dante
Priority: normal Milestone: 1.2
Component: Dojox Version: 1.1.0
Severity: normal Keywords:
Cc: stuff@…

Description

I have created a patch to enable controlling the slide direction when using the dojox.layout.RadioGroupSlide?

To use see the examples in the tests attached.

I have already had a CLA accepted for Paul Edmondson stuff at hootbah.co.uk

Patches made against the trunk rev 13290

Attachments

RadioGroup.js.diff (1.5 kB) - added by guest 8 months ago.
dojox.layout.RadioGroup?.js diff
test_RadioGroup.html.diff (2.9 kB) - added by guest 8 months ago.
dojox.layout.tests.test_RadioGroup.html diff
radio.diff (9.8 kB) - added by dante 8 months ago.

Change History

Changed 8 months ago by guest

dojox.layout.RadioGroup?.js diff

Changed 8 months ago by guest

dojox.layout.tests.test_RadioGroup.html diff

Changed 8 months ago by bill

  • summary changed from Slide direction control for dojox.layout.RadioGroup.js to [patch] [cla] Slide direction control for dojox.layout.RadioGroup.js

Changed 8 months ago by dante

  • owner changed from peller to dante
  • milestone set to 1.2

great.

I actually have a patch for this made up as an enhancement, but it worked by reading a custom slideFrom attribute on the child panes. would that not make more sense? I'd like personally to be able to control each individual pane. attached is my patch in progress, which might not show up properly as it lives in the old trunk repo.

Changed 8 months ago by dante

Changed 7 months ago by dante

  • status changed from new to closed
  • resolution set to fixed

(In [13709]) fixes #6481 - adds ability to specify direction of incoming slide based on new param mixed into _Widget. defaults to "random". Changes default hasButtons to false in hopes to deprecate soon, though test still uses it. also adds zTop var, to handle top zindex, because panes sliding in simply overlay the old widget now. also fixed an unreported bug about onShow firing too soon (now onEnd of the animation).

Note: See TracTickets for help on using tickets.