Ticket #6438 (closed task: fixed)

Opened 8 months ago

Last modified 5 months ago

BorderContainer: should have border on slider

Reported by: bill Owned by: nonken
Priority: normal Milestone: 1.2
Component: Dijit - LnF Version: 1.1.0
Severity: normal Keywords: alex
Cc:

Description (last modified by bill) (diff)

See http://download.dojotoolkit.org/release-1.1.0/dojo-release-1.1.0/dojox/layout/tests/test_ExpandoPane.html.

Splitters don't have their own borders, making them appear to "end" at the wrong place when what they butt up against doesn't include a border.

Taken from Alex's email.

Attachments

border.png (10.7 kB) - added by bill 8 months ago.
ie6.png (6.8 kB) - added by bill 6 months ago.
problem with horizontal splitter on IE6

Change History

Changed 8 months ago by bill

Changed 8 months ago by bill

  • description modified (diff)

Changed 8 months ago by bill

See also #6437. Be careful that fixing this "problem" could exacerbate that one.

Changed 8 months ago by bill

And also, #6460.

Changed 7 months ago by bill

(In [13740]) Fix bug w/doLayout=true mode where it would effectively double the ContentPane?'s padding, but setting a style="left: 5px; top: 5px;" on the child even though it isn't position:absolute.

Refs #6438. !strict

Changed 6 months ago by bill

(In [13897]) Layout widget class changes:

  • Add class attribute to all layout widgets to control class name on domNode (dijitTabContainer, dijitBorderContainer, etc.)
  • Children of layout containers get composite classname specifying parent. ex: a ContentPane? inside of a BorderContainer? will get the class "dijitBorcontainer-dijitContentPane". This is to replace "dijitBorderContainer > dijitContentPane" type selectors which don't work on IE6.
  • refactor of addChild()/removeChild()/_setupChild() to share common code

Refs #6437, #6438 (these changes are necessary to setup CSS rules to get borders to show up correctly for various parent/child relationships)

!strict

Changed 6 months ago by nonken

  • status changed from new to closed
  • resolution set to fixed

Closed, Refs #6437, #6764

Changed 6 months ago by nonken

To clarify, splitters should not have borders since the direct children of a BorderContainer? will provide the borders to make the sliders appear bordered.

Changed 6 months ago by bill

problem with horizontal splitter on IE6

Changed 6 months ago by bill

  • status changed from closed to reopened
  • resolution deleted

I'm just seeing one problem w/the horizontal splitter in themeTester.html on IE6. There's no top border (IE, presumably the bottom border of the top TabContainer? is getting cutoff):

problem with horizontal splitter on IE6

Can we fix that somehow?

Changed 5 months ago by bill

  • milestone changed from 1.3 to 1.2

Changed 5 months ago by bill

  • status changed from reopened to closed
  • resolution set to fixed

(In [14392]) Make BorderContainer panes have a higher z-index than the splitters so that off-by one errors don't obscure the border on the panes. Fixes #6438 !strict.

Changed 5 months ago by bill

(In [14410]) Fix regression from [14392] breaking gutters=false. Refs #6438, fixes #7161.

Changed 5 months ago by bill

(In [14426]) Rollback accidental checkin of experimental change in [14410]. Fixes #7166, refs #6438, #7161.

Changed 5 months ago by peller

(In [14540]) Make example look nice again by cluttering markup :-P refs #6438

Note: See TracTickets for help on using tickets.