Ticket #6437 (new task)

Opened 4 months ago

Last modified 7 weeks ago

nested layout widgets borders should collapse

Reported by: bill Owned by: nonken
Priority: normal Milestone: 1.3
Component: Dijit - LnF Version: 1.1.0
Severity: normal Keywords: alex
Cc:

Description (last modified by bill) (diff)

See the panes tab on test_ExpandoPane.html. It's an AccordionContainer nested inside of a TabContainer. The borders of the TabContainer and the AccordionContainer nest to give an unpleasant effect:

Notice the dark line, which isn't there for other tabs.

Taken from Alex's email.

Attachments

nested.png (12.6 kB) - added by bill 4 months ago.

Change History

Changed 4 months ago by bill

Changed 4 months ago by bill

  • description modified (diff)

Changed 4 months ago by bill

See also #6438; fixing that may make this problem worse.

Also, note that the example list above could be worked-around by adding style="border: none" to the nested AccordionContainer, but for a TabContainer inside an AccordionContainer (the reverse of the example above), I'm not even sure what it should look like. Maybe not worth worrying about.

Changed 7 weeks ago by bill

(In [13897]) Layout widget class changes:

  • Add class attribute to all layout widgets to control class name on domNode (dijitTabContainer, dijitBorderContainer, etc.)
  • Children of layout containers get composite classname specifying parent. ex: a ContentPane? inside of a BorderContainer? will get the class "dijitBorcontainer-dijitContentPane". This is to replace "dijitBorderContainer > dijitContentPane" type selectors which don't work on IE6.
  • refactor of addChild()/removeChild()/_setupChild() to share common code

Refs #6437, #6438 (these changes are necessary to setup CSS rules to get borders to show up correctly for various parent/child relationships)

!strict

Changed 7 weeks ago by nonken

(In [13916]) added ContentPane? styleheet to support nested layouts, refs #6437

Changed 7 weeks ago by nonken

(In [13917]) added ContentPane? specific rules for nested layouts, refs #6437

Changed 7 weeks ago by nonken

(In [13920]) Added Accordion, BorderContainer? rules for nested layouts, refs #6437

Changed 7 weeks ago by nonken

(In [13922]) added test for graphical user interface, refs #6437

Note: See TracTickets for help on using tickets.