Ticket #6409 (closed enhancement: fixed)

Opened 8 months ago

Last modified 4 months ago

Widgets don't completely scroll into view when they receive focus.

Reported by: clown Owned by: doughays
Priority: normal Milestone: 1.2
Component: Dijit Version: 1.1.0
Severity: normal Keywords:
Cc: becky, davidb

Description

Consider "../dijit/tests/form/test_Slider.html". There are a couple of vertical sliders on this test page.

If the slider is not fully scrolled into view and the thumb is moved using the keyboard, then it is possible to move the thumb off of the viewable area of the page. It continues to move, but it is not visible.

Tested on FF2, FF3, IE7, IE6 (WinXP), and FF2, FF3 (Mac).

Attachments

6409.patch (3.3 kB) - added by doughays 7 months ago.
new dijit.scrollIntoView
6409.2.patch (6.9 kB) - added by doughays 7 months ago.
new patch that handles nested scrollbars

Change History

Changed 8 months ago by bill

  • owner set to doughays

Giving to Doug, unless one of the a11y folks wants to grab it.

Changed 7 months ago by doughays

new dijit.scrollIntoView

Changed 7 months ago by doughays

  • summary changed from Slider: Vertical sliders don't completely scroll into view when they receive focus. to Widgets don't completely scroll into view when they receive focus.

Changed 7 months ago by clown

I tested keyboard support using "../dijit/tests/form/test_Slider.html" after applying 6409.patch (FF2, FF3, IE6, IE7 on WinXP, and FF2, FF3 on Mac OS X Tiger). It works well in terms of scrolling sliders fully into view (I didn't check any other widgets).

I did discover issues with IE6 and FF, which I traced to dojo.getComputedStyle(), and have filed a new ticket -- see 6657.

Changed 7 months ago by doughays

new patch that handles nested scrollbars

Changed 7 months ago by doughays

  • status changed from new to closed
  • resolution set to fixed

(In [13710]) Fixes #6409 !strict. Redesigned dijit.scrollIntoView to handle horizontal scrolling, right-to-left, and nested scrollbars. Called scrollIntoView automatically onfocus of a widget. Added automated test.

Changed 6 months ago by bill

  • status changed from closed to reopened
  • resolution deleted

[13710] breaks Dialog on IE6 in RTL mode. http://archive.dojotoolkit.org/dojo-2008-05-12/dojotoolkit/dijit/tests/test_Dialog.html?dir=rtl works but http://archive.dojotoolkit.org/dojo-2008-05-13/dojotoolkit/dijit/tests/test_Dialog.html?dir=rtl is broken. Pushing "show dialog" doesn't show it.

Changed 6 months ago by doughays

  • status changed from reopened to closed
  • resolution set to fixed

(In [14101]) Fixes #6409. Rewrote dijit.scrollIntoView. Added enhanced test files and a simple doh test.

Changed 4 months ago by bill

  • status changed from closed to reopened
  • resolution deleted

I think this checkin caused a problem w/test_InlineEditBox.html, clicking the "state of purchase" ComboBox for the first time. It gets an exception that "parent is undefined" on FF3/mac and Safari/mac at least.

Can you check if this is the cause? (If not can open other ticket instead)

Changed 4 months ago by doughays

This was and is fixed. The unrelated InlineEditBox? problem appars to be caused by bill's [13989] change.

Changed 4 months ago by doughays

  • status changed from reopened to closed
  • resolution set to fixed

Changed 4 months ago by bill

As per above problem (my previous comment), see #7395.

Note: See TracTickets for help on using tickets.