dojox.data.XmlStore _getDeleteUrl method borked

[freelock]

In 1.1.0, it's at line 964:

if (!this.url !== "") {

... this snippet always resolves to true, and the next line returns this.url. However, there's some useful code immediately after that, which appends the item keyvalue to the query string before submitting, which can never execute.

Suggest removing this if block entirely.

[freelock]

Suggested patch, to replace this method and fix for appending to existing query string as well as stripping "@" from attributes:

		var url = this.url;
		if (item && this.keyAttribute !== "") {
			var value = this.getValue(item, this.keyAttribute);
			if (value) {
				var key = this.keyAttribute.charAt(0) ==='@' ? this.keyAttribute.substring(1): this.keyAttribute;
				url += url.indexOf('?') < 0 ? '?' : '&';
				url += key + '=' + value;
			}
		}
		return url;	//string

I'll be happy to sign a CLA--where do I start?

[peller]

dojotoolkit.org/cla

[freelock]

CLA for Freelock LLC submitted via email.

--John Locke

[jaredj]

Fixed in revision 13298 or later.