Safari 3.1 is crashing at times

[nathan]

It appears to be related to dojo._mixin.

By process of elimination, using the file dojox/form/test/test_PasswordValidator.html, it appears to be happening during the first unit test on that page - when it calls dojo.query("[widgetId]")

Calling dojo.query("*") at that same point works fine.

commenting out the dojo.query lines works (except for the tests fail).

Tracing through the code, I found that commenting out line 12 in dojo/_base/NodeList.js would eliminate the crash (though, obviously, nothing else would work correctly).

[dylan]

It sounds like it is related to http://bugs.webkit.org/show_bug.cgi?id=17313 , though I thought this would be fixed in time for Safari 3.1.

[alex]

what version, *exactly* of Dojo is this against? The given query is most likely related to the last set of comments in:

http://trac.dojotoolkit.org/ticket/5832

And the patch in:

http://trac.dojotoolkit.org/changeset/13066

Should fix it.

[alex]

gonna mark as fixed. Please re-open if you're still seeing crashes on the latest Dojo nightlies (and paste in the crash-log).

[nathan]

Yes - this is fixed. It was using a checkout from yesterday (13137) - the patch in:

http://trac.dojotoolkit.org/changeset/13142

looks like it was actually the one that fixed it. This I think should have been a duplicate (at least the crashing part) of #5832.