Ticket #6250 (closed defect: fixed)

Opened 8 months ago

Last modified 7 months ago

[patch] Create auto scrolling TimeTextBox widget

Reported by: nathan Owned by: nathan
Priority: normal Milestone: 1.2
Component: DojoX Form Version: 1.0
Severity: normal Keywords:
Cc: haysmark

Description (last modified by nathan) (diff)

It's a more "natural" way of doing things, the clicks would still works, but it would be nice to have it autoscroll when hovering over the buttons.

The hover-based scroll would probably fire a bit sooner, and wouldn't accelerate quite as much.

Attachments

TimeTextBox.patch (7.2 kB) - added by nathan 8 months ago.
Implements a dojox.form.TimeTextBox? widget (really, it just extends dijit._TimePicker). Also includes a test case - which is mostly a copy of dijit/tests/form/test_TimeTextBox.html

Change History

  Changed 8 months ago by nathan

  • description modified (diff)

  Changed 8 months ago by nathan

  • summary changed from Make dijit._TimePicker scroll automatically on hover of the up or down buttons to [patch] Make dijit._TimePicker scroll automatically on hover of the up or down buttons

  Changed 8 months ago by peller

  • cc haysmark added
  • owner changed from nathan to haysmark

  Changed 8 months ago by doughays

  • milestone set to 1.2

  Changed 8 months ago by nathan

  • owner changed from haysmark to nathan
  • component changed from Dijit to DojoX Form

Moving to dojox.form - probably should exist there for some "bake time".

  Changed 8 months ago by nathan

  • summary changed from [patch] Make dijit._TimePicker scroll automatically on hover of the up or down buttons to Create auto scrolling TimeTextBox widget

follow-up: ↓ 9   Changed 8 months ago by doughays

Want to make sure that hovering over the buttons doesn't cause autoscroll to happen, and then refire again since you may still be hovering over the button in the case of several pages and no scrollbar.

Changed 8 months ago by nathan

Implements a dojox.form.TimeTextBox? widget (really, it just extends dijit._TimePicker). Also includes a test case - which is mostly a copy of dijit/tests/form/test_TimeTextBox.html

  Changed 8 months ago by nathan

  • summary changed from Create auto scrolling TimeTextBox widget to [patch] Create auto scrolling TimeTextBox widget
  • milestone changed from 1.2 to 1.1

Created patch with the fix implemented in dojox.form.

in reply to: ↑ 7   Changed 8 months ago by nathan

Replying to doughays:

Want to make sure that hovering over the buttons doesn't cause autoscroll to happen, and then refire again since you may still be hovering over the button in the case of several pages and no scrollbar.

Yeah - the way that scrolling is implemented in dijit._TimePicker isn't really "scrolling". On click of the buttons, it just redraws the content (and only the visible content is drawn). This allows for wrap-around scrolling.

The patch here just kicks off a typematic trigger on hover of the button - the same as it would fire off on click of the button.

  Changed 8 months ago by nathan

  • owner changed from nathan to dante
  • description modified (diff)

  Changed 8 months ago by nathan

Reassigning to Dante for proxy commit

  Changed 8 months ago by nathan

  • owner changed from dante to nathan
  • status changed from new to assigned

  Changed 8 months ago by nathan

Having problems attaching patches to this bug as well.... There is a patch at http://www.toonetown.com/projects/downloads/TimePicker_HoverScroll-6250-04-04_1343.diff

which puts this mechanism back in dijit as an option to be passed to dijit._TimePicker (hoverScroll=true) - defaults to false. Also contains a test case for setting it to true.

  Changed 8 months ago by nathan

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [13267]

  Changed 8 months ago by nathan

  • status changed from closed to reopened
  • resolution deleted

Reopening until we can get a consensus on what should happen here with the TimePicker?.

  Changed 7 months ago by toonetown

  • status changed from reopened to closed
  • resolution set to fixed

(In [13450]) Fixes #6250: hoverScroll on by default - not as an option

Note: See TracTickets for help on using tickets.