Ticket #6240 (assigned defect)

Opened 8 months ago

Last modified 7 hours ago

put DND CSS classes into theme

Reported by: bill Owned by: nonken
Priority: normal Milestone: 1.4
Component: Dijit - LnF Version: 1.0
Severity: normal Keywords:
Cc: elazutkin

Description (last modified by elazutkin) (diff)

Currently the unofficial "theme" for DND is defined in source:dojo/trunk/tests/dndDefaults.css but it should be part of each theme for dijit.

Also, could cleanup the CSS some. For example, the avatar has a rectangle surrounded by a rounded rectangle (Eugene says this looks really bad.)

It's also possible using simple CSS rules that during drag, to tone down all irrelevant elements on the page highlighting all valid targets, which is a good usability feature especially for visually impaired .

Note that the themes do already have some DnD classes, see source:dijit/trunk/themes/tundra/Common.css, but it doesn't define things like dojoDndItemSelected. In any case, source:dijit/trunk/tests/test_Tree_Notification_API_Support.html and source:dijit/trunk/tests/tree/test_Tree_DnD.html should not be importing dndDefault.css.

Change History

Changed 8 months ago by bill

  • description modified (diff)

Changed 8 months ago by bill

  • component changed from Dijit to Dijit - LnF

Changed 8 months ago by elazutkin

  • description modified (diff)

#6395 is the dup. But it assumes the default DnD CSS, which will be overridden by themes.

Changed 5 months ago by nonken

  • status changed from new to assigned
  • milestone changed from 1.2 to tbd

To enable easier styling we need to put a separate "test" with the markup being statically on a page, it is very hard otherwise to style and improve the interface

Changed 3 months ago by dylan

  • milestone changed from tbd to future

Changed 3 months ago by nonken

  • milestone changed from future to 1.3

Changed 7 hours ago by bill

  • milestone changed from 1.3 to 1.4
Note: See TracTickets for help on using tickets.