[patch] ComboBox/Editor: various height elements not working

[bill]

Not sure if this is a ComboBox problem or an Editor/FontPlugIn problem...

The larger items in the font-size drop down overlap each other

Reproduced on FF2, IE7.

[bill]

screenshot

[haysmark]

It has to do with this code in dojo/resources/dojo.css:

ol li, ul li {
font-size:1em;
line-height:1.5em;
margin:0pt;
}

When I turn off font-size and line-height in Firebug I get a very different-looking menu.

[haysmark]

Same popup without global dojo.css li rules.

[bill]

Ah thanks for finding this. Hmm, I'm not sure how we should address this. Options are:

• modify dojo.css, either
  • removing that line-height rule since it will also mess up developers that setup a different font-size on their lists w/out adjusting line-height too.
  • Alternately, could it be changed to use margin or padding rather than line-height?
• override that setting for ComboBox's drop down
• override that setting just for the Editor
• something else

[haysmark]

Fixes #6189. Set the line-height on each of the options in ComboBoxMenu? to normal.

[haysmark]

IMO setting global styles in dojo.css seems pretty wonky to me, but here is a patch to fix ComboBoxMenu?.

[bill]

(In [14295]) Fixes #6189: ComboBox/Editor?: various height elements not working