Ticket #6113 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

[patch][cla]Regression in dijit.form.Form / parsing

Reported by: dante Owned by: alex
Priority: high Milestone: 1.1
Component: Dijit Version: 1.0
Severity: blocker Keywords:
Cc:

Description

as of the nightly: http://archive.dojotoolkit.org/dojo-2008-03-06/dojotoolkit/dijit/tests/form/Form.html

the Form unit test shows three failures in IE6

It fails when dojo.parser.parse is run over the content containing a <form dojoType="dijit.form.Form"> I was able to comment out the dojoType for the form, and the textboxs render and work properly, though the existence of a form causes the parser to die, completely.

Attachments

6113_dojo.patch (1.4 kB) - added by doughays 8 months ago.
fix to dojo/tests/_base/html.html testcase
6113_dijit.patch (1.3 kB) - added by doughays 8 months ago.
fix to dijit/tests/form/form.html testcase

Change History

Changed 9 months ago by bill

  • cc doughays added
  • owner set to simonjb

Root cause is that dojo.attr(formNode, "onsubmit", myFunc); is failing on the delete node[name] (where name=="onsubmit"). So I guess this is a dojo.attr() problem. Not sure who to assign to, maybe simon?

Changed 9 months ago by doughays

  • cc alex added; doughays removed

This is a regression that started failing with dojo core revision [12899].

Changed 9 months ago by bill

  • cc alex removed
  • owner changed from simonjb to alex

Changed 9 months ago by alex

  • status changed from new to closed
  • resolution set to fixed

(In [13004]) update form processing to work on IE. Fixes #6113. Updates test page and docs in dijit.form.Form as well. !strict

Changed 9 months ago by bill

  • status changed from closed to reopened
  • resolution deleted

Thanks for fixing the regression in dojo.attr(), but your change to Form.html breaks the unit test (at least on IE6). To reproduce: load Form.html in IE6 and look at firebug-lite console.

Changed 9 months ago by bill

Also, the attribute map unit test is failing (at least on IE6).

Changed 9 months ago by alex

thanks. will track it down.

Changed 8 months ago by doughays

fix to dojo/tests/_base/html.html testcase

Changed 8 months ago by doughays

fix to dijit/tests/form/form.html testcase

Changed 8 months ago by peller

  • summary changed from Regression in dijit.form.Form / parsing to [patch][cla]Regression in dijit.form.Form / parsing

Changed 8 months ago by alex

  • status changed from reopened to closed
  • resolution set to fixed

fixed in r13120

Note: See TracTickets for help on using tickets.