Ticket #6081 (new defect)

Opened 9 months ago

Last modified 9 months ago

Tooltip connectId should support one id/node

Reported by: rcoup Owned by:
Priority: normal Milestone: 1.3
Component: Dijit Version: 1.0
Severity: normal Keywords: tooltip
Cc:

Description

Came up on IRC:

  • works: <div dojoType="dijit.Tooltip" connectId="id1" ...>
  • works: <div dojoType="dijit.Tooltip" connectId="id1,id2" ...>
  • works: new dijit.Tooltip({connectId:["id1"], ...})
  • doesn't: new dijit.Tooltip({connectId:"id1", ...})

Considering its named and documented as connectId (not plural) it should probably work that way. Something like the attached would do the trick.

Attachments

tooltip_connectId.patch (416 bytes) - added by rcoup 9 months ago.

Change History

Changed 9 months ago by rcoup

Changed 9 months ago by bill

This is from [10942]/#3429. I agree the name is confusing, and should have been changed to widgetIds. Although I don't like the precedent of supporting different signatures to the constructor. Will think about it.

Changed 9 months ago by rcoup

Well, it can connect to any DOM node, not just a widget. connectIds would be better. Main thing is that it doesn't catch people out :)

The parser syntax for arrays is IMHO (and ptwobrussell's) a bit too magical and that confuses people, but that's a different issue.

Changed 9 months ago by bill

  • version set to 1.0
  • milestone set to 1.3

Oops, I meant to say "connectIds" not "widgetIds"... just a typo. Ping me on IRC sometime and tell me how you think the parser should handle arrays.

Note: See TracTickets for help on using tickets.