Ticket #599 (closed task: fixed)

Opened 3 years ago

Last modified 14 months ago

TimePicker: implement

Reported by: jan831@… Owned by: haysmark
Priority: normal Milestone: 1.0
Component: Dijit Version: 0.3
Severity: normal Keywords:
Cc:

Description

A more elaborate version of the time picker would be nice

features to have: custom format, showing hours also in 24h-format, a more graphical way of selecting a time, ...

IMHO this is a nice intuitive way of picking times and time intervals:

(warning java-applet!!) http://java.arcadevillage.com/applets/timepica.htm

Attachments

599.patch (0.8 kB) - added by haysmark 14 months ago.
Refs #599. Added a TimeTextBox?+TimePicker? to themeTester.

Change History

Changed 3 years ago by anonymous

  • version changed from 0.2 to 0.4

Changed 2 years ago by dylan

  • status changed from new to assigned
  • owner changed from anonymous to dylan
  • milestone set to 0.4

Changed 2 years ago by dylan

  • version changed from 0.4 to 0.3
  • milestone changed from 0.4 to 0.5

Changed 19 months ago by bill

  • owner changed from dylan to haysmark
  • status changed from assigned to new
  • milestone changed from 0.9 to 1.0

This would be good for 1.0; Mark, do you want to try this (if there is time)?

Changed 18 months ago by peller

  • component changed from Widgets to Dijit

Changed 18 months ago by peller

  • priority changed from low to normal
  • type changed from enhancement to task
  • summary changed from enhanced time picker to new time picker widget

See also #1874, #1872, #2477

Changed 16 months ago by haysmark

  • status changed from new to assigned

Changed 16 months ago by bill

(In [9697]) Added a graphical _TimePicker based on the Calendar API. Added TimeTextbox?, a slightly more general DateTextbox? with the _TimePicker as a popup widget. DateTextbox? extends TimeTextbox?, uses a Calendar instead of a _TimePicker. DateTextbox? uses the correct toISOString arguments to only submit the date. Fixes #3782. Refs #599.

Code from Mark Hays (IBM, CCLA on file)

Changed 16 months ago by bill

Cool this looks good; a few things I noticed:

  • clickableIncrementHeight is a CSS property and should be specified in dijit.css (or maybe tundra.css), not via javascript
  • createOption also sets some other CSS properties that should be set in dijit.css (ie, you should set div.className but never div.style)
  • "calendar" should be renamed to "popup" or something more generic
  • this line seems strange and unnecessary, as lang is defined in _Widget.js:

lang:this.lang,

Changed 16 months ago by peller

Looks great!

The TimePicker? does not seem to show the initial selection.

also, _TimePicker should probably live in the same package as _Calendar for symmetry. I chose not to put _Calendar in form because it in itself is not a form element. The "_" isn't really for private, it's just to mark the class as unsupported standalone for a11y reasons.

Changed 16 months ago by bill

(In [9897]) Refactored inlined TimePicker? styles into dijitTimePicker classes. Added additional comments. Refs #599.

Patch from Mark Hays (IBM, CCLA on file)

Changed 16 months ago by bill

  • summary changed from new time picker widget to TimePicker: implement

This is essentially finished but needs some bug fixing to display the current time selected, and also tundra theme.

Changed 16 months ago by haysmark

Tundra task assigned in #4133.

Changed 14 months ago by haysmark

  • status changed from assigned to closed
  • resolution set to fixed

It's implemented. Other tickets open for other issues.

Changed 14 months ago by haysmark

Refs #599. Added a TimeTextBox?+TimePicker? to themeTester.

Changed 14 months ago by peller

(In [10802]) Add TimeTextBox? to themeTester, but fix localization issues first. You can't fix on en-us without loading it, and I think setting an example of fixed locales is going to mislead users. Refs #599.

Note: See TracTickets for help on using tickets.