Ticket #5973 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

[cla][patch][test]TitlePane not easily subclassed

Reported by: nathan Owned by: bill
Priority: normal Milestone: 1.1
Component: Dijit Version: 1.0
Severity: normal Keywords:
Cc:

Description

TitlePane? is not very easily subclassed - since the _setCss function operates on focusNode. The end result is that a subclass cannot move focusNode off of the title bar (although, it may be desirable - for example, to have *ONLY* the arrow be the focus node).

In the included patch is a test case (in the form of a patch to tests/test_TitlePane.html) that demonstrates moving the nodes around.

The suggested fix is to create a new attach point (called, in this patch "titleBarNode") and use that node for the _setCss functions.

Attachments

TitlePane-Focus.patch (3.7 kB) - added by guest 9 months ago.
Allows the focusNode to be moved, if desired.

Change History

Changed 9 months ago by guest

Allows the focusNode to be moved, if desired.

Changed 9 months ago by guest

Patch submitted by Nathan Toone

Changed 9 months ago by bill

  • reporter changed from guest to nathan@toonetown.com

Changed 9 months ago by bill

  • owner set to bill
  • status changed from new to assigned
  • milestone set to 1.1

Changed 9 months ago by bill

  • status changed from assigned to closed
  • resolution set to fixed

(In [12697]) Fixes #5973: make TitlePane? more easy to subclass by separating out titleBarNode and focusNode as separate attach points. Patch from Nathan Toone (CLA on file)

Changed 9 months ago by nathan

  • reporter changed from nathan@toonetown.com to nathan
Note: See TracTickets for help on using tickets.