ValidationTextBox etc: remove default invalid tooltip

[bill]

ValidationTextBox? displays the tooltip "The value entered is not valid" whenever a value is invalid. See this block of code in ValidationTextBox?:

// invalidMessage: String
// 		The message to display if value is invalid.
invalidMessage: "$_unset_$", // read from the message file if not overridden

Want to remove this and not display any tooltip, unless the developer has specified a more useful message (like "use format (999) 123-4567"). Presumably the developer has specified format and required-ness in the label of the field already.

Becky said: I think we can live without the default tooltip but I'll have to double check with the Accessibility Center. Whenever the invalid icon is displayed the ARIA role should also be set to "invalid" so the screen reader will get the information. However, there is no guarantee that a sighted person will understand the invalid icon - the tooltip provides a textual description. While I believe the icon is sufficient, the Accessibility Center makes the final call.

So assigning this to Becky.

See also #5982. If we remove the default invalid message should probably also remove the default missing message.

[bill]

Note that upon fixing this, both missingMessage and invalidMessage should be removed from the message file (validate.js).

See related ticket #5982.

[doughays]

I think this ticket should be reconsidered. I rather like the invalid message. Also, since the drop of the partial matching code, the invalid message is seen MUCH less.

[becky]

remove default invalid message

[becky]

The patch is here - I just need to know whether to commit it or not. If we go ahead with this I'll also look at removing the messages from validate.js.

[bill]

BTW the comment // read from the message file if not overridden should also be removed.

[bill]

We discussed this on IRC and there wasn't a clear consensus; I'd say people were actually leaning towards keeping the message as it has some marginal value differentiating between out-of-range, missing, and more generic invalid states (like typing letters in a numeric field). Anyway, I'm going to close it for now.