Ticket #5956 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

dojox.validate.isValidCreditCard loops forever

Reported by: guest Owned by: peller
Priority: normal Milestone: 1.1
Component: Dojox Version: 1.0
Severity: major Keywords:
Cc: bill@…, tk, dante

Description

Try this in Firebug:

dojo.require("dojox.validate");
dojo.require("dojox.validate.creditCard");
dojox.validate.isValidCreditCard("4111 1111 1111 1111", "vi");

The result is that dojox.validate.isValidLuhn() appears to go into an infinite loop. However note that running isValidLuhn() works as expected (returns true almost immediately):

dojox.validate.isValidLuhn("4111 1111 1111 1111");

The problem appears to occur with both 1.0.2 and in the svn head.

We discovered this because a client was complaining that their customers' browsers were hanging when entering an order. Not a good way to run an ecom business. :-/

-- Bill / bitranch

Change History

Changed 9 months ago by peller

  • milestone set to 1.1

Changed 9 months ago by peller

  • cc tk, dante added

Changed 9 months ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [12675]) don't do a dojo.indexOf on a hash. Fixes #5956

Note: See TracTickets for help on using tickets.