Ticket #5917 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

ComboBox ESC key / revert problem

Reported by: doughays Owned by: haysmark
Priority: normal Milestone: 1.1
Component: Dijit Version: 1.1b1
Severity: normal Keywords:
Cc:

Description

Run dijit/tests/for/test_ComboBox.html
Focus on the first box (Iowa) and type something.
Press the Esc key.
The field blanks out and fires onChange.
The field should have reverted to Iowa and no onChange fired.

Attachments

5917.patch (3.0 kB) - added by haysmark 9 months ago.
Fixes #5917. Fix escape key handling in ComboBox?.

Change History

Changed 9 months ago by haysmark

This is a regression in [10872]. I documented the regression in my review of the patch; see #4633. The issue was fixed for FilteringSelect? but not ComboBox?.

Changed 9 months ago by haysmark

Fixes #5917. Fix escape key handling in ComboBox?.

Changed 9 months ago by doughays

  • status changed from new to closed
  • resolution set to fixed

(In [12597]) Fixes #5917. Changed ComboBoxMixin? to use the _FormWidget:_onKeyPressed to manage undo.

Note: See TracTickets for help on using tickets.