Ticket #5899 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

[cla][patch][unit test]dojo DeferredList return broken (plus fix for typo)

Reported by: tvachon Owned by: dmachi
Priority: high Milestone: 1.1
Component: General Version: 1.0
Severity: normal Keywords:
Cc:

Description

Currently, the following code:

var d1 = new dojo.Deferred();

var d2 = new dojo.Deferred();
var dl = new dojo.DeferredList([d1, d2]);
dl.addCallback(function(res){
    console.log(res);                
});
d1.callback("foo");
d2.callback("bar");

prints a list like [undefined, [true, "foo"], [true, "bar]] to the console, when it should be printing [[true, "foo"], [true, "bar"]]

Attached patch fixes this and adds some basic regression tests.

Attachments

dojoDeferredList.patch (3.8 kB) - added by tvachon 9 months ago.
Patch to fix problem + tests. (Updates to remove variable and not fix typo, since it's already been fixed in changeset 12508)

Change History

Changed 9 months ago by peller

  • priority changed from normal to high
  • owner changed from anonymous to dmachi
  • summary changed from dojo DeferredList return broken (plus fix for typo) to [patch][cla?][unit test]dojo DeferredList return broken (plus fix for typo)
  • milestone set to 1.1

Changed 9 months ago by tvachon

Patch to fix problem + tests. (Updates to remove variable and not fix typo, since it's already been fixed in changeset 12508)

Changed 9 months ago by tvachon

  • summary changed from [patch][cla?][unit test]dojo DeferredList return broken (plus fix for typo) to [patch][unit test]dojo DeferredList return broken (plus fix for typo)

CLA submitted 2/19/2008.

Changed 9 months ago by dylan

  • summary changed from [patch][unit test]dojo DeferredList return broken (plus fix for typo) to [cla][patch][unit test]dojo DeferredList return broken (plus fix for typo)

Changed 9 months ago by dmachi

  • status changed from new to closed
  • resolution set to fixed

(In [12994]) fix deferredList. fixes #5899 and adds test file. thanks tvachon

Note: See TracTickets for help on using tickets.