Ticket #5840 (assigned defect)

Opened 9 months ago

Last modified 23 hours ago

ContentPane onUnload event is called on programatic tab creation

Reported by: guest Owned by: bill
Priority: normal Milestone: 1.3
Component: Dijit Version: 1.0
Severity: normal Keywords:
Cc:

Description (last modified by bill) (diff)

this problem happens only when I specify the href for the ContentPane?.

In ContentPane?.js file, _downloadExternalContent function calls the unload event handler.

_downloadExternalContent: function(){
	this._onUnloadHandler();
         ...

I don't know why unload event handler is there.

Test page attached.

cheers

Attachments

tabs_test.html (2.2 kB) - added by guest 9 months ago.
tab1.html (9 bytes) - added by guest 9 months ago.
tab2.html (10 bytes) - added by guest 9 months ago.

Change History

Changed 9 months ago by guest

Changed 9 months ago by guest

Changed 9 months ago by guest

Changed 9 months ago by peller

  • owner changed from anonymous to mumme
  • component changed from General to Dijit

just guessing, but it's probably trying to trigger unload on any content which may be getting replaced. Does this result in a problem for you? Do you have a test case?

Changed 9 months ago by guest

Well, i am doing an action and some clean-up onUnload. In my case it was easy to do a work-around checking if an element exist before performing the action and trying to delete it. so my application works but dojo calling its onUnload event is wrong.

Do you have a test case?

I attached a minimal example to show the bug. or what do you mean by "test case"?

regards,

prajwala & eduardo

Changed 9 months ago by peller

sorry, I see the example files now. thanks for posting them.

Changed 9 months ago by dylan

  • milestone set to 1.1

Changed 8 months ago by bill

  • milestone changed from 1.1 to 1.2

Move all milestone 1.1 tickets to 1.2, except for reopened tickets and tickets opened after 1.1RC1 was released.

Changed 2 months ago by bill

  • owner changed from mumme to sfoster
  • milestone changed from 1.2 to 1.3

Sam can you take a look at these? Hopefully these are fixed by your refactor or you can fix them

Changed 23 hours ago by bill

  • owner changed from sfoster to bill
  • status changed from new to assigned
  • description modified (diff)

I've been mucking in ContentPane, might as well fix this. I think it should just check the isLoaded flag and not call the onUnload handler() if it isn't set.

Note: See TracTickets for help on using tickets.