Ticket #5832 (closed enhancement: fixed)

Opened 3 months ago

Last modified 7 weeks ago

provide native branch for dojo.query() for latest WebKit and/or Safari 3.1

Reported by: alex Owned by: alex
Priority: normal Milestone: 1.1
Component: General Version: 1.0
Severity: normal Keywords:
Cc: nathan

Description

as we've always planned for, browsers are starting to implement the native CSS selector APIs. Dojo 1.1's dojo.query() should be updated to deferr to these APIs when available.

Change History

Changed 3 months ago by alex

  • status changed from new to closed
  • resolution set to fixed

(In [12371]) update dojo.query to defer to [node].querySelectorAll() if it's available. Fixes #5832. !strict

Changed 3 months ago by bill

  • status changed from closed to reopened
  • resolution deleted

Changed 3 months ago by alex

Apple's on it:

http://bugs.webkit.org/show_bug.cgi?id=17313

I'm not keen to roll it back...it's their bug to fix.

Changed 2 months ago by alex

(In [13066]) update query() to move combinator-rooted queries off to a non-querySelectorAll branch until the webapis WG decides that they're the right thing to do (which they clearly are). Refs #5832. !strict

Changed 8 weeks ago by nathan

I'm think that this is related to bug #6252...maybe their fix didn't get in before safari 3.1 was released? I have verified this by rolling back these two changes and it fixes the crash in Safari 3.1

Would you potentially be a bit more keen on rolling it back, since it's now affecting the released version of Safari?

Changed 8 weeks ago by alex

lets not roll back. Other browsers are sporting QSA, and the right thing to do is to work around Webkit. A check like:

if((dojo.isSafari && dojo.isSafari > 3.1)&&(...)){
}

Changed 8 weeks ago by nathan

  • cc nathan added

I agree. I think that would be an appropriate solution.

Changed 7 weeks ago by alex

verified w/ the webkit team that this bug:

http://bugs.webkit.org/show_bug.cgi?id=17313

didn't land in time for Safari 3.1. WIll apply a patch to our side.

Changed 7 weeks ago by alex

  • status changed from reopened to closed
  • resolution set to fixed

(In [13142]) ensure that we don't blow up on Safari 3.1. Fixes #5832. !strict

Note: See TracTickets for help on using tickets.