Ticket #5827 (closed defect: duplicate)

Opened 5 months ago

Last modified 5 months ago

Safari Detection Broken

Reported by: benschell Owned by: alex
Priority: normal Milestone:
Component: General Version: 1.0
Severity: normal Keywords:
Cc:

Description

Due to the fix in r12330, Safari detection is broken. Specifically, dojo.isSafari is set to 2 on Firefox (rather than undefined, the previous behavior), despite the fact that it is (obviously) not Safari.

Examining the contents of r12330 and comparing to previous behavior, the problem is on line 96, where idx is not checked to be >= 0 (as it was previously).

Patch attached.

Attachments

5827.patch (0.7 kB) - added by benschell 5 months ago.
Fixes the aforementioned problem.

Change History

Changed 5 months ago by benschell

Fixes the aforementioned problem.

Changed 5 months ago by bill

  • owner changed from anonymous to alex

Changed 5 months ago by peller

  • status changed from new to closed
  • resolution set to duplicate

I reopened #5575. Not sure the patch works, since the operator can't operate on -1 the way you'd want it to.

Note: See TracTickets for help on using tickets.