Ticket #5761 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

Height-less Grid still displays header nodes

Reported by: benschell Owned by: benschell
Priority: normal Milestone:
Component: DojoX Grid Version: 1.0
Severity: normal Keywords:
Cc:

Description

After some testing related to #5343, I've found that, even when the Grid sizes itself to 0px tall (due to it's parent not having an appropriate height set), the column headers still appear. If the Grid is sizing itself to a zero height, the column headers should be hidden as well, otherwise the Grid appears broken (when in fact it's just not displayed).

Attachments

5761.patch (1.7 kB) - added by benschell 10 months ago.
Fixed absolute paths in previous patch
dojox.grid.VirtualGrid_20080212.patch (1.6 kB) - added by jaredj 9 months ago.
Minor cleanup of Ben's patch.

Change History

Changed 10 months ago by benschell

  • status changed from new to assigned

I've included a modification to the test_sizing.html test file which includes a Grid instance in an unsized container. The behavior can be seen with the given fix not included. The rest of the patch corrects the behavior.

Changed 10 months ago by benschell

Fixed absolute paths in previous patch

Changed 9 months ago by jaredj

Talked with Ben on this and I agree with his fix. If the parent container has 0 size, then nothing of the grid should display. Otherwise, it does appear broken that the header displays, but no data. It tends to suggest that the data model is wrong somehow when it actually wasn't.

Changed 9 months ago by jaredj

Minor cleanup of Ben's patch.

Changed 9 months ago by jaredj

  • status changed from assigned to closed
  • resolution set to fixed

(In [12420]) Applying patch from Ben Shell. Minor fix. Fixes #5761 !strict

Note: See TracTickets for help on using tickets.