ItemFileWriteStore chokes with reverting deletedItems

[benschell]

I've attached a test case. Using an existing data set, the organization is as follows:

Africa
|
|-----------|
Kenya     Egypt 
|
Nairobi

If you delete Egypt and Nairobi (doesn't matter the order), then attempt to revert the store and execute a new query, IFWS throws an error. In the given example, the _S (reference to the store) on the Kenya item has gone to null.

If referenceIntegrity is turned off, there are no issues.

[jaredj]

Located the problem. It's in the handling of modifiedItems and keeping the array of top level items consistent. The wring index was being used. Simple fix, turns out. Patch forthcoming.

[jaredj]

Updated patch to include a unit test for this problem. Will commit after running tests against multiple browsers as well as doh via rhino turns up clean.

[jaredj]

Browsers tested:

FireFox? 2.0.0.11: PASSED.

FireFox? 1.5.0.12: PASSED.

IE 6.0: PASSED.

IE 7.0: PASSED.

Opera 9.2: PASSED.

SeaMonkey? 1.1.2: PASSED.

Safari B3: PASSED.

D.O.H. executed with Rhino (commandline): PASSED.

[jaredj]

(In [12275]) Fix to ItemFileWriteStore? for reversion bug. refs #5743 !strict

[jaredj]

(In [12276]) Fix comment typo. refs #5743 !strict

[jaredj]

Backport of fix from 1.1 + alternate testcase for issue.

[jaredj]

Dojo 1.0.X tested on:

Browsers tested:

FireFox?? 2.0.0.11: PASSED.

FireFox?? 1.5.0.12: PASSED.

IE 6.0: PASSED.

IE 7.0: PASSED.

Opera 9.2: PASSED.

SeaMonkey?? 1.1.2: PASSED.

Safari B3: PASSED.

D.O.H. executed with Rhino (commandline): PASSED.

[jaredj]

(In [12277]) Backport of fix to revert code. fixes #5743 !strict