Ticket #5730 (closed defect: invalid)

Opened 10 months ago

Last modified 3 months ago

Grid resize can fail if parent node doesn't exist in 1.0.2 (fix for 4892 is incorrect)

Reported by: guest Owned by: BryanForbes
Priority: normal Milestone: 1.2
Component: DojoX Grid Version: 1.0
Severity: major Keywords:
Cc:

Description (last modified by toonetown) (diff)

While resizing my grids, I keep getting a "this.domNode has no properties" error from the VirtualGrid resize function.

The fix to ticket #4892 put the !this.domNode check too low down in the function, so it's after the line that checks !this.domNode.parentNode.

The if (!this.domNode) return; line added in changelist r11308 should be removed, and the if (!this.domNode.parentNode) at the start of the function should be changed to if (!this.domNode || !this.domNode.parentNode) return; to make sure this.domNode exists before trying to use it.

Change History

Changed 10 months ago by guest

There should be an "or" in the suggested "if" in between the this.domNode and this.domNode.parentNode. The editor ate the two vertical bar characters.

Changed 10 months ago by peller

  • description modified (diff)

Changed 10 months ago by peller

  • description modified (diff)

Changed 9 months ago by dylan

  • milestone set to 1.1

Changed 9 months ago by sorvell

  • milestone changed from 1.1 to 1.2

The grid should always have a domNode so this should never happen. Adding a simple check here would be fine if it's really necessary, but we need to determine why it's necessary. (There is a check for the domNode existence that entirely aborts rendering.)

A test case showing how/when resize failed with this error would be extremely helpful.

Changed 3 months ago by BryanForbes

  • owner changed from sorvell to BryanForbes

Changed 3 months ago by toonetown

  • status changed from new to closed
  • resolution set to invalid
  • description modified (diff)

Closing as invalid - now that the grid doesn't actually render until startup is called, this issue should not be present anymore...startup shouldn't be called until the grid has been attached to the DOM.

If this issue still exists in recent nightlies, reopen with a test case and/or more information on how to reproduce.

Note: See TracTickets for help on using tickets.