Ticket #5689 (closed enhancement: fixed)

Opened 17 months ago

Last modified 3 months ago

[patch][cla] BorderContainer collapsible feature

Reported by: peller Owned by: dante
Priority: normal Milestone: 1.4
Component: Dijit Version: 1.0
Severity: normal Keywords: BorderContainer
Cc:

Description

Not sure what to call this exactly -- please make suggestions here -- but I think we need an option on the edge panes to have a little icon, sort of like an AccordionPane?, to collapse/expand the pane in the layout. Shouldn't be too hard to do.

Attachments

expandoPane_20080219.patch (1.5 kB) - added by sfoster 17 months ago.
[CLA] [PATCH] Adds (partial) support for vertical orientation expand/collapse.

Change History

Changed 17 months ago by peller

  • summary changed from BorderContainer expando feature to BorderContainer collapsible feature

Changed 17 months ago by dante

(In [12404]) experimental expandopane in dojox - refs #5689 test has working bordercontainer with three children (two expando's and a tab in the center). left expando has three tabs (bottom aligned) and center tab has accordionContainer. right expando has AccordionContainer? as child.

Changed 17 months ago by sfoster

[CLA] [PATCH] Adds (partial) support for vertical orientation expand/collapse.

Changed 17 months ago by sfoster

  • cc dante added

expandoPane_20080219.patch goes some way towards supporting expand/collapse in vertical as well as horizontal orientation for the dojox.layout.ExpandoPane?. Sorry, didnt get to tests and css but I wanted to put this back on the stack for the next person.

Changed 17 months ago by dante

(In [12518]) refs #5689 - add top/bottom expando option based on sfoster's patch. adds new test, and other cleanups.

Changed 15 months ago by peller

  • cc bill, dante removed
  • owner changed from peller to dante
  • component changed from Dijit to DojoX Widgets

Changed 15 months ago by bill

  • owner deleted
  • component changed from DojoX Widgets to Dijit

I'd like for this to be in dijit eventually, possibly a different architecture where the code is in BorderContainer? itself not in a separate widget.

Changed 14 months ago by dylan

  • owner set to dante
  • summary changed from BorderContainer collapsible feature to [patch][cla] BorderContainer collapsible feature

What's the plan on this?

Changed 14 months ago by dante

to be merged w/ genro's patch pending CLA reception. sent friday, allegedy. refs #6781

Changed 14 months ago by bill

  • milestone changed from 1.2 to 1.3

Let's do the integration of collapsability into dijit for 1.3; 1.2 is focusing on purely visual issues.

As I said above, I hadn't envisioned doing this as a separate widget (ie, requiring the user to use an ExpandoPane to wrap their "real" widget), but rather to have it built in to BorderContainer, although it's up for discussion.

In any case, need to make sure the borders show up correctly so should wait for Nikolai to finish the refactoring (#6437, #6438, #6768). (Note that nesting a TabContainer inside an ExpandoPane could exacerbate the border problem.)

Changed 10 months ago by dante

I want to say this is fixed. There is a ToggleSplitter in DojoX, though iirc requires you to subclass BorderContainer and overwrite the private _splitterClass variable?

ExpandoPane provides any leftover use case functionality. Thinking about it, it may be possible for ExpandoPane to be title-less, but that just makes it a ContentPane with a ToggleSplitter setup, huh?

Changed 8 months ago by bill

  • milestone changed from 1.3 to 1.4

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

Changed 3 months ago by dante

  • status changed from new to closed
  • resolution set to fixed

The goal is to make ExpandoPane? work and merge into Dijit (afaik). Marking this as fixed because this was part of the motiviation. Obviously there are other UI nits that could come of this, but the basic premise is some sort of toggle-able pane needs to exist in BC. Expando has the most momentum.

Note: See TracTickets for help on using tickets.