Ticket #5625 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

Error in doh.registerTestNs logic

Reported by: ptwobrussell Owned by: alex
Priority: normal Milestone: 1.1
Component: TestFramework Version: 1.0
Severity: normal Keywords:
Cc:

Description

I noticed a comment on http://dojotoolkit.org/book/dojo-book-0-9/part-4-meta-dojo/d-o-h-unit-testing

that appears to be correct. Didn't see a ticket already filed on it, so I wanted to add it in here. The basic issue seems to be that the logic is supposed to ignore functions with a leading _, but the logic in place accepts them exclusively.

From that page:

doh.registerTestNs = function(/*String*/ group, /*Object*/ ns)

line 331:

if( (x.charAt(0) == "_") &&

should be changed to

if( (x.charAt(0) != "_") &&

Change History

Changed 3 months ago by alex

  • status changed from new to closed
  • resolution set to fixed

(In [12610]) update doh.registerTestNs logic to correctly filter for privates. Fixes #5625. !strict

Changed 3 months ago by alex

  • milestone set to 1.1
Note: See TracTickets for help on using tickets.