Ticket #560 (closed enhancement: fixed)

Opened 2 years ago

Last modified 15 months ago

Dojo builds should not re-define the root Dojo object if included twice

Reported by: alex Owned by: jburke
Priority: normal Milestone:
Component: Core Version: 0.2
Severity: normal Keywords:
Cc:

Description

When a dojo.js file is included twice, it does not do the "right thing". Both builds and the "source" version of Dojo should include prevention for this.

Change History

Changed 2 years ago by alex

  • owner changed from alex to jburke
  • milestone changed from 0.3release to 0.3.1

not sure if this should 0.3, 0.3.1, or 0.4. Moving to 0.3.1.

Changed 2 years ago by jburke

Alex, how much should be protected? Just redefining the base dojo object, or the whole dojo.hostenv object? What problem is the bug trying to solve? Maybe just having to re-download packages? If so, then I think just making sure dojo is not reset to an empty object is enough.

Changed 2 years ago by alex

I think what we're looking for here is an if(){} statement around everything inside of whatever dojo.js happens to be in play. In essence, we don't want to run *anything* in a re-included dojo.js if the dojo.* namespace is already created.

Changed 2 years ago by jburke

  • status changed from new to closed
  • resolution set to fixed

Fixed in 4185.

Changed 15 months ago by anonymous

  • milestone deleted

Milestone 0.3.1 deleted

Note: See TracTickets for help on using tickets.