Ticket #5503 (closed enhancement: fixed)

Opened 18 months ago

Last modified 12 months ago

dojox.grid.data.DojoData markupFactory could use constructorFunction param

Reported by: guest Owned by: alex
Priority: normal Milestone: 1.2
Component: DojoX Grid Version: 1.0
Severity: normal Keywords:
Cc: juho.manninen@…

Description (last modified by sorvell) (diff)

Currently DojoData? class name is hard-coded in its markupFactory. This seems unnecessary and makes inheriting DojoData? class more complicated. There's an easy solution: the parser passes the current class to the markupFactory method. See http://localhost/dojo.ssh/dojox/grid/tests/test_tundra_edit.html for discussion.

Change History

Changed 16 months ago by sorvell

  • owner changed from sorvell to alex
  • description modified (diff)
  • milestone changed from 1.1 to 1.2

So it looks like changing the markupFctory function in dojox.grid.data.DojoData? will work:

markupFactory: function(args, node, constructorFunction){
  return new constructorFunction(null, null, args);
}

Passing this to Alex to confirm and implement. Thanks.

Changed 16 months ago by alex

perhaps more to the point in general we should be using more expressive markupFactory handlers for dojox.grid.*. I'll handle one for dojox.grid.Grid first and then do the DojoData? one second (although I hope we need that markupFactory less and less).

Changed 16 months ago by alex

(In [12902]) add a new, greatly simplified, style of table construction from HTML tables and make working with dojo.data stores stupidly easy. Event handlers aren't 100% and lots of stuff isn't fully configurable from the new table markup syntax just yet, but for getting someone started with the grid, this is the new hotness.

Refs #5503

Changed 12 months ago by BryanForbes

  • status changed from new to closed
  • resolution set to fixed

Fixed in [14193].

Note: See TracTickets for help on using tickets.