Ticket #5482 (closed defect: invalid)

Opened 5 months ago

Last modified 2 months ago

Dojo Book: IE fails on several pages "Internet Explorer cannot display the page"

Reported by: frankf Owned by: criecke
Priority: normal Milestone:
Component: book Version: 1.0
Severity: normal Keywords: documentation ie cannot display page
Cc: frank.fortson@…

Description

See Forum Discussion.

On one (or several) demo pages in the Dojo Book, a script line is included as the last line inside a div to be explicitly parsed. The script line, inside the div, calls for parsing the same div that includes that script line.

Firefox handles this, but IE doesn't.

Moving the script line (parser) just outside the div to be parsed works for both FF and IE.

Attachments

ieprob.html (1.2 kB) - added by guest 5 months ago.
Documentation: IE cannot display certain demo pages

Change History

Changed 5 months ago by guest

Documentation: IE cannot display certain demo pages

Changed 5 months ago by pottedmeat

  • owner changed from pottedmeat to criecke
  • component changed from Documentation to book

Changed 4 months ago by peller

  • owner changed from criecke to bill

Bill, should the script tag work inside the div? If not, let's document it (wontfix) and just fix the book -- we'll address that through book comments on a thread somewhere rather than in trac.

Changed 4 months ago by bill

Technically I don't think you should be have <script> tags inside <body> (rather than <head>) at all, but as a practical matter maybe it's OK except for the case mentioned in this ticket. I'd consider this a bug in the book's examples, not in dojo or IE.

Changed 4 months ago by peller

  • status changed from new to closed
  • resolution set to invalid

at least in the editor example, the culprit was apparently the fact that the call to parse was not in an addOnLoad, triggering a timing problem. It's established that this should have occurred after onload, so that much isn't a bug.

Changed 2 months ago by frankf

  • status changed from closed to reopened
  • resolution deleted
  • reporter changed from guest to frankf

Since this problem with the "book" continues to be mentioned in the forums (people using IE can't view pages in the Book of Dojo that have this problem--looks bad for Dojo), can this be assigned to the book maintainer?

Latest posting about it: forum

From some testing I did, I believe the fix is to wrap the offending script function in a dojo.addOnLoad. 

<script>dojo.parser.parse(dojo.byId("code1"));</script>

like this: 

<script>
  dojo.addOnLoad(function(){dojo.parser.parse(dojo.byId("code1"));});
</script>

This was probably closed due to the discussion turning to whether there was a defect in Dojo or not. It is really a mis-coding in the Book of some of the examples, most of which use a div with an id like "code1", "code2", etc. Then loads dojo and the requires nearby and within or just after the code1 div, call the parser on that same code1 block.

Changed 2 months ago by peller

  • owner changed from bill to criecke
  • status changed from reopened to new

I made the change to the Dialog page. I'm cc'ing Craig so he's aware of the issue, as it's probably necessary to do a scan of the book for this sort of thing, but I don't think Craig uses trac much so this probably is not the way to resolve the issue, and we have established that it's not a bug in the toolkit. Posting comments directly to the pages is the way to go, and ping someone with book access if it doesn't get fixed (or if you've sent in a CLA and you want edit access, maybe we can add more people to the list?) We do need to get all of these instances fixed, though.

Changed 2 months ago by peller

  • status changed from new to closed
  • resolution set to invalid

Changed 2 months ago by frankf

Thanks. I believe a comment has been added to at least one page, not positive. I'll be glad to go through and find/make the changes, if needed. Email is in the cc field.

Note: See TracTickets for help on using tickets.