Ticket #5351 (closed defect: fixed)

Opened 12 months ago

Last modified 8 months ago

destroy dialog fails to disconnect its modal intercepts

Reported by: dmachi Owned by: dante
Priority: normal Milestone: 1.1
Component: Dijit Version: 1.0
Severity: normal Keywords:
Cc:

Description

Certain keys will fail to work if you destroy() a dialog instead of or without hide()ing it first. Making sure to hide() it first, ensures _modalConnects are disconnected, so they dont' get lost when the widget is destroy()d

Attachments

DialogDestroy.patch (394 bytes) - added by dante 12 months ago.
fix
dialog.patch (1.1 kB) - added by dante 10 months ago.
updated patch takes more into consideration
tryMe.patch (1.3 kB) - added by dante 10 months ago.
and the winner is …
5351.diff (1.2 kB) - added by BryanForbes 10 months ago.

Change History

Changed 12 months ago by dante

  • owner set to dante
  • status changed from new to assigned

Changed 12 months ago by dante

fix

Changed 10 months ago by dante

updated patch takes more into consideration

Changed 10 months ago by dante

and the winner is ...

Changed 10 months ago by BryanForbes

Changed 10 months ago by dante

(In [12065]) refs #5351 - test case for focus, and keyboard events.

Changed 10 months ago by dante

  • status changed from assigned to closed
  • resolution set to fixed

(In [12068]) fixes #5351 - modal connects not being disconnected in a lot of destroy/hide combinations. accomodates focus state, but simply destroy's the underlay and bgiframe etc.

Changed 8 months ago by bill

(In [13106]) Fix link in test; refs #5351.

Note: See TracTickets for help on using tickets.