Editor foreground and background color plugins don't operate correctly

[guest]

If no text is selected and a background color is chosen, typing does not get colored. It ought to, just as it does with the foreground color. Also the selected color for either plugin should stay selected, that is the button ought to stay depressed (toggle) until it is pressed again. Or at least this should be settable behavior through some argument to the plugin. Also, we suggest, that the selected color might be used to color the button background color and that the icon be transparent to let the color so the user can see what color is selected.

[peller]

looks like some browser quirks we should try to normalize, if we can: when there's no selection, Safari disables the background color, FF ignores it, and IE colors the entire word. The easy way out would be to disable the command whenever there is no selection for all browsers.

The color toolbar icon overlay is a nice idea for an enhancement, but right now I don't think we convey the current selection state at all in the color picker, which would also be nice. These are all separate issues.

[jeffg]

Just to clarify, when a foreground color is selected it ought to become and remain the current color used for all subsequent typing. And the background color ought to behave the same.

Then there's the question of what to do when the user selects text. For my use case, I don't want selection to affect the ability of the user to select the foreground/background text color. So I say, do nothing in the case of selection.

[dylan]

mass move of editor issues to 1.2.