QueryReadStore: getLabel (from FileItemReadStore)

[guest]

Even though it clearly says in QueryReadStore?'s getLabel-function: "Override it to return whatever the label shall be, see Read-API.", I feel that a default implementation would be valuable. Plus, it's relatively simple to implement by recycling FileItemReadStore?. FileItemReadStore? allows setting label just like the identifier - in response data object.

The getLabel-function:

getLabel: function(/* item */ item){
    if(this._labelAttr && this.isItem(item)){
        return this.getValue(item,this._labelAttr); //String
    }
    return undefined; //undefined
},

In addition, it would require setting label somewhere in _fetchItems:

this._labelAttr = data.label;

[wolfram]

implemented label functions and tests, fixed getAttributes() test, which i had screwed by modifying the PHP file last time

[wolfram]

please commit

[jaredj]

(In [13008]) Adding in patch for getLabel provided by wolfram. refs #5257 !strict

[jaredj]

Tested on:

Firefox 2.0.0.12 Safari B3: IE 6 Seamonkey 1.1.2 IE 7

Passed.

Closing as fixed.