Ticket #5180 (closed enhancement: fixed)

Opened 12 months ago

Last modified 5 months ago

Move Gears detection out of Dojo Base

Reported by: jburke Owned by: jburke
Priority: normal Milestone: 1.2
Component: BuildSystem Version: 0.9
Severity: normal Keywords:
Cc:

Description (last modified by jburke) (diff)

Gears detection should be a Dojo Core module, but not part of Dojo Base. Cleared it on dojo-contributors.

Change History

Changed 12 months ago by jburke

  • type changed from defect to enhancement

Changed 12 months ago by elazutkin

Q: does it need to be in the core in the first place? E.g., in gfx the detection code is in a file, which belongs to gfx --- if you don't use gfx, you don't pay for it, which seems to be not the case for google gears.

Changed 12 months ago by jburke

I'm all for moving it out of base. I'll ask Alex if it needs to be in base.

Changed 9 months ago by jburke

  • milestone changed from 1.1 to 1.2

I plan on moving the gears code out of base and into a Core dojo.gears module. I floated the idea on dojo-contributors, and the response was positive. However, I really need to test the dojox.off code when I do that change. I have not used it or gears before, so I am not likely to get this done before the beta build for 1.1. It would have been nice to save some bytes for base, but it will have to wait.

Changed 5 months ago by jburke

  • description modified (diff)
  • summary changed from Build option to exclude Google Gears detection to Move Google Gears out of Dojo Base

Changed 5 months ago by jburke

  • summary changed from Move Google Gears out of Dojo Base to Move Gears detection out of Dojo Base

Changed 5 months ago by jburke

  • status changed from new to closed
  • resolution set to fixed

(In [14293]) Fixes #5180: move gears detection out of Dojo Base. Now in a dojo.gears module. Tested change in FF3 with Gears, using dojox.off and dojox.storage demos. \!strict

Note: See TracTickets for help on using tickets.