Ticket #5160 (closed defect: fixed)

Opened 12 months ago

Last modified 12 months ago

dojo.Declaration does event connections on the prototype functions

Reported by: pottedmeat Owned by: alex
Priority: highest Milestone: 1.0.1
Component: Dijit Version: 1.0
Severity: blocker Keywords:
Cc:

Description

If we've created a class using a type="dojo/connect" script block, the even is fired across all instances of the class.

var wcp = dojo.getObject(this.widgetClass).prototype;
scripts.forEach(function(s){
  var event = s.getAttribute("event");
  dojo.connect(wcp, event || "postscript", null, dojo.parser._functionFromScript(s));
});

Change History

Changed 12 months ago by pottedmeat

  • owner changed from slightlyoff to alex

Changed 12 months ago by peller

Do we hold up 1.0.1 for this, or should this be for 1.0.2?

Changed 12 months ago by alex

  • status changed from new to assigned

we absolutely need this for 1.0.1

Changed 12 months ago by alex

(In [11541]) make sure that <script type="dojo/connect"> works correctly. Refs #5160

Changed 12 months ago by pottedmeat

  • status changed from assigned to closed
  • resolution set to fixed

(In [11542]) Fixes #5160. Merge r11541 into 1.0 branch.

Note: See TracTickets for help on using tickets.