Ticket #5033 (closed defect: fixed)

Opened 6 months ago

Last modified 6 months ago

i18n demo: China missing from Asia

Reported by: peller Owned by: bill
Priority: normal Milestone: 1.0.1
Component: Dijit Version: 0.9
Severity: normal Keywords:
Cc:

Description

Reported by a user here http://dojotoolkit.org/comment/reply/4181/8299

Looks like the continent property is missing for some entries. Is this a problem with the original data or the transform script?

Change History

Changed 6 months ago by bill

It's sort of a problem w/the original data in the sense that http://en.wikipedia.org/wiki/ISO_3166-1 and http://en.wikipedia.org/wiki/List_of_countries_by_continent aren't an exact text match for China (and perhaps other countries).

Does anyone have a better data source to use to generate the data?

Changed 6 months ago by bill

Oh I guess I found the answer to my own question: http://en.wikipedia.org/wiki/List_of_countries_by_continent_(data_file)

Changed 6 months ago by peller

Cool, so in the spirit of keeping impact "minimal" for 1.0.1, I'd suggest we just manually fix up China on the branch and then redo the data for 1.1. Make sense?

Changed 6 months ago by peller

(In [11479]) Associate China with Asia. Refs #5033

Changed 6 months ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [11480]) Associate China with Asia. Fixes #5033

Changed 6 months ago by peller

applied patch to 1.0.1 fix up China only. More comprehensive solution now moved to #5082

Note: See TracTickets for help on using tickets.