Ticket #4971 (closed defect: fixed)

Opened 13 months ago

Last modified 9 months ago

toolbar with dropdowns (editor font choices) broken on IE

Reported by: peller Owned by: peller
Priority: high Milestone: 1.1
Component: Dijit Version: 0.9
Severity: normal Keywords:
Cc:

Description

because they're not popups, the focus is not managed correctly. Fix for 1.0 or remove support for this feature until this is fixed.

Change History

Changed 13 months ago by bill

There is an infrastructure for this, but it's complicated because you have to restore focus and selection *before* executing the font-change. Look at Menu.js for a related example. I think it would work something like:

  • when toolbar gets the synthetic _onFocus() event, call {{prevFocus = dijit.getFocus(this); }}} to save the previous focus and selection from the <div> (there's a bit of magic in that it remembers that the <div> was focused even though focus has already moved to something else; it remembers the last focused item)
  • somehow the toolbar's children widgets need to have access to that prevFocus variable so they can restore focus+selection before executing themselves. Or maybe you can setup before-advice on the children to restore focus and selection before they execute.

Changed 13 months ago by peller

(In [11325]) Take font dropdowns out of the test, since they don't yet work in IE. Refs #4971.

Changed 13 months ago by peller

  • owner changed from peller to liucougar
  • milestone changed from 1.0 to 1.1

Cougar, can you take a look at this? I tried using the focus code as well as calling the editor's bookmark code directly to save/restore focus, but nothing worked. It appears that Editor may already be trying to do this on behalf of the plugin. So why is there a focus problem only on IE? It almost looks like a cross-domain issue trying to access the iframe?

Changed 12 months ago by peller

  • priority changed from normal to high

Changed 12 months ago by peller

blocking the use of the feature in #4171

Changed 11 months ago by peller

(In [11884]) FontChoice? editor plugin should have been marked 'experimental'. Refs #4971, Refs #4171

Changed 11 months ago by peller

(In [11885]) FontChoice? editor plugin should have been marked 'experimental'. Refs #4971, Refs #4171

Changed 10 months ago by peller

  • cc alex added

this is a must have for 1.1

Changed 10 months ago by peller

  • cc alex removed
  • owner changed from liucougar to alex

Changed 9 months ago by alex

  • status changed from new to assigned

Changed 9 months ago by peller

(In [12768]) Use bookmarks (working now) to control selection and focus. Refs #4971

Changed 9 months ago by peller

  • owner changed from alex to peller
  • status changed from assigned to new

Changed 9 months ago by peller

(In [12770]) Remove 'experimental.' Refs #2439, #4171, #4971

Changed 9 months ago by peller

(In [12772]) Avoid setting font properties on update. onChange seems to fire on setValue as well as user interaction. Refs #4171, #4971

Changed 9 months ago by peller

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.