Ticket #4836 (closed defect: invalid)

Opened 13 months ago

Last modified 4 months ago

document.documentElement.clientWidth in ie quirks mode

Reported by: guest Owned by: sjmiles
Priority: normal Milestone: 1.2
Component: HTML Version: 0.9
Severity: normal Keywords:
Cc:

Description

when dojo.isIE and document.compatMode == "BackCompat?" both true, the document.documentElement.clientWidth is always be zero, so dojo._fixIeBiDiScrollLeft(dojo/_base/html.js line 824 revision 11061) will get a wrong value in this situation.

Attachments

html.js.patch (0.6 kB) - added by guest 13 months ago.

Change History

Changed 13 months ago by guest

  Changed 9 months ago by dylan

  • summary changed from document.documentElement.clientWidth in ie quirks mode to [patch][needs cla] document.documentElement.clientWidth in ie quirks mode
  • milestone set to 1.2

Who is this patch from? Is there a CLA on file?

  Changed 5 months ago by peller

trivial enough that a CLA is not needed. Can we apply this patch?

follow-up: ↓ 4   Changed 5 months ago by sjmiles

The current code has some logic based on BackCompat? that is different than this patch. 

var de = dd.compatMode == "BackCompat" ? dd.body : dd.documentElement;

It looks likely that it addresses this problem, but no test file was provided.

Unless somebody can provide more info, I'm going to mark this as 'invalid'.

in reply to: ↑ 3   Changed 5 months ago by sjmiles

Replying to sjmiles:

It looks likely that it addresses this problem, but no test file was provided.

I mean to say there is no test attached to this ticket that I can use to verify this problem.

  Changed 4 months ago by bill

  • status changed from new to closed
  • resolution set to invalid
  • summary changed from [patch][needs cla] document.documentElement.clientWidth in ie quirks mode to document.documentElement.clientWidth in ie quirks mode

Marking invalid since no test case. This is probably fixed anyway (see above).

Note: See TracTickets for help on using tickets.