Ticket #4812 (closed defect: fixed)

Opened 13 months ago

Last modified 13 months ago

_TimePicker and _Calendar should be peers

Reported by: peller Owned by: peller
Priority: normal Milestone: 1.0
Component: Dijit Version: 0.9
Severity: normal Keywords:
Cc: bill

Description

We agonized over this and ended up putting _Calendar in dijit since it's not a form. Even though they're private for a11y reasons, in theory they can be used standalone w/o a form. Whatever we do, I think they ought to live in the same place.

Let's confirm with Bill et al

Change History

Changed 13 months ago by haysmark

I put TimePicker? in form just because only TimeTextBox?, a form widget, uses it. I would think Calendar would follow the same logic.

I tried putting a TimePicker? in a standalone page and it kind of . . . exploded. I think it is heavily dependent on the popup code.

Because they are private do we skip deprecation of the old spot if we move one?

Changed 13 months ago by peller

yes, the private mark gives us some flexibility. it's nice, IMO, if the subwidget doesn't rely on popups or the parent (like _Calendar), but I guess it's not a requirement.

Changed 13 months ago by bill

  • owner changed from haysmark to peller

OK, let's put them both in base.

Changed 13 months ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [11130]) Move dijit.form._TimePicker to dijit. Fixes #4812

Note: See TracTickets for help on using tickets.