Ticket #4502 (closed defect: worksforme)

Opened 22 months ago

Last modified 7 months ago

TabContainer: Several bugs when adding tabs programatically

Reported by: guest Owned by: peller
Priority: normal Milestone: 1.3
Component: Dijit Version: 0.9
Severity: normal Keywords:
Cc: tk

Description (last modified by peller) (diff)

I noticed the problems in test_TabContainer_remote.html . - When adding a tab , and selecting different tabs , the css styles won't always change as they should to selected , not selected .
- When adding more than one tab , the new tabs will have 1px cutoff in between the button and the tab area
- When adding more tabs , so that a second line of tabs i required , the first tab showing up on the second line , doesn't create a second line , it just overlaps the content . The same tab also doesn't show up at the start of the first line , instead shows up somewhere in the middle
- When adding even more tabs , the second line gets created but tabs are still starting from the middle

Attachments

tabtest1.html (1.3 kB) - added by guest 20 months ago.

Change History

Changed 22 months ago by peller

  • owner deleted
  • component changed from General to Dijit

Changed 21 months ago by peller

  • owner set to peller

Changed 21 months ago by tk

  • cc tk added

Testing this, it appears to be a race condition for layout() calling TC.layout() after wrapping the first tab.... fixes the 2nd row immediately.... Alignment... I dont have a good CSS tool to play with here (just FirebugLite?)

Changed 21 months ago by peller

  • milestone set to 1.1

Changed 20 months ago by guest

Changed 20 months ago by guest

I noticed another drawing bug when programatically adding tabs to an empty tab container. See attached tabtest1.html for example. It looks slightly different in firefox 2.0 (windows) and IE6, but neither draw it correctly.

Changed 17 months ago by bill

  • summary changed from Several bugs when adding tabs programatically to a tab container to TabContainer: Several bugs when adding tabs programatically

Changed 16 months ago by peller

  • milestone changed from 1.1 to 1.2

will attempt rewrite of TabContainer? layout in 1.2. look at this then.

Changed 10 months ago by peller

  • description modified (diff)

tk, can you reproduce the original problem? Multiple tab rows appear to wrap properly in trunk. I can only see the error in the test case included here.

Changed 10 months ago by peller

  • milestone changed from 1.2 to 1.3

Changed 10 months ago by bill

(In [15137]) Fixes #5821, fixes #7594: programatically adding tab to empty TabContainer? fails. Problem was that we were querying size of tab strip before any tabs had been created, thus it was coming out as 0.

May also help fix part of #4502 (refs #4502).

!strict

Changed 8 months ago by peller

the only problem I can see remaining is a missing pixel on the current test. Is there anything else? I'd be inclined to file that as a new, low-priority ticket.

Changed 7 months ago by peller

  • status changed from new to closed
  • resolution set to worksforme
Note: See TracTickets for help on using tickets.