Ticket #4421 (closed defect: wontfix)

Opened 15 months ago

Last modified 3 months ago

[cla][patch] Safari and dijit.Editor

Reported by: guest Owned by: doughays
Priority: normal Milestone: 1.2
Component: Editor Version: 0.9
Severity: normal Keywords:
Cc: hannes.wyss@…

Description (last modified by peller) (diff)

Hi there!

I posted some Patches back in 2006 to get Editor2 working with Safari - and now I'm at it again for dijit.Editor :)

So far, I've managed to get Font-Formatting and Alignment working, mainly by preventing Safari from losing the selection on click.

I've also implemented a Html-Source editing plugin, which I'm happy to share if you're interested. For that I needed to fix RichText#replaceValue?() - is there any particular reason why there is no catch-all that just hands the call off to setValue?

Finally I had an issue where Safari would only display the text-value, with all html-formatting stripped.

I'm attaching a patch with these three changes.

thanks for any feedback you can give me

cheers, Hannes

Attachments

dojo.editor.patch (6.6 kB) - added by guest 15 months ago.

Change History

Changed 15 months ago by guest

Changed 15 months ago by dylan

  • owner changed from anonymous to alex
  • summary changed from Safari and dijit.Editor to [cla][patch] Safari and dijit.Editor
  • milestone set to 1.0

cla confirmed, alex, please take a look at the patch.

Changed 9 months ago by peller

Hannes, sorry this has gotten stale again. Are these patches still required for Safari 3? We've since dropped support for Safari 2.

Changed 9 months ago by dylan

  • milestone changed from 1.1 to 1.2

mass move of editor issues to 1.2.

Changed 5 months ago by peller

  • component changed from General to Editor
  • description modified (diff)

still don't know if any of this is needed in the Safari 3+ world. Without a confirmation we should probably close as wontfix.

Changed 3 months ago by peller

  • owner changed from alex to doughays

Some of this patch appears to already be in trunk. Doug can you look at some of the remaining parts like the mousedown event handler? Clearly, if it's specific to 2.0.4, we should wontfix.

Changed 3 months ago by bill

  • type changed from enhancement to defect

Changed 3 months ago by doughays

  • status changed from new to closed
  • resolution set to wontfix

I tested with Safari 3.1.2 on WinXP and these problems appear to be fixed.

Note: See TracTickets for help on using tickets.